Bug 127317 - UserContentController should keep track of user scripts
Summary: UserContentController should keep track of user scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-20 15:38 PST by Anders Carlsson
Modified: 2014-01-20 16:04 PST (History)
0 users

See Also:

Attachments
Patch (10.22 KB, patch)
2014-01-20 15:39 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (10.53 KB, patch)
2014-01-20 15:57 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-20 15:38:26 PST 
UserContentController should keep track of user scripts
Comment 1 Anders Carlsson 2014-01-20 15:39:07 PST 
Created attachment 221700 [details]
Patch
Comment 2 Andreas Kling 2014-01-20 15:53:06 PST 
Comment on attachment 221700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221700&action=review

> Source/WebCore/page/UserContentController.cpp:79
> +    auto scripts = it->value.get();

Could this be a reference instead?
Comment 3 Andreas Kling 2014-01-20 15:53:44 PST 
Comment on attachment 221700 [details]
Patch

Actually no. This is crashy on EWS :|
Comment 4 Anders Carlsson 2014-01-20 15:57:49 PST 
Created attachment 221701 [details]
Patch
Comment 5 Anders Carlsson 2014-01-20 16:04:35 PST 
Committed r162384: <http://trac.webkit.org/changeset/162384>