Bug 127236 – Modernize HTML parser code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Modernize HTML parser code

[Anders Carlsson]

Created attachment 221571 [details]
Patch

[Andreas Kling]

Comment on attachment 221571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221571&action=review

r=me

> Source/WebCore/html/parser/CSSPreloadScanner.cpp:214
> -            OwnPtr<PreloadRequest> request = PreloadRequest::create("css", url, baseElementURL, CachedResource::CSSStyleSheet);
> +
> +            auto request = std::make_unique<PreloadRequest>("css", url, baseElementURL, CachedResource::CSSStyleSheet, String());
>              // FIXME: Should this be including the charset in the preload request?
> -            m_requests->append(request.release());
> +            m_requests->append(std::move(request));

I'd lose the temporary.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:388
> -            m_insertionPreloadScanner = adoptPtr(new HTMLPreloadScanner(m_options, document()->url(), document()->deviceScaleFactor()));
> +            m_insertionPreloadScanner = std::make_unique< HTMLPreloadScanner>(m_options, document()->url(), document()->deviceScaleFactor());

Extra space after < here.

> Source/WebCore/html/parser/HTMLResourcePreloader.cpp:66
>  void HTMLResourcePreloader::takeAndPreload(PreloadRequestStream& r)
>  {
> -    PreloadRequestStream requests;
> -    requests.swap(r);
> +    PreloadRequestStream requests = std::move(r);

This is a bit awkward.

[Anders Carlsson]

Committed r162275: <http://trac.webkit.org/changeset/162275>