Bug 127228 - CStack: Switching Windows port to using the C Loop LLINT
Summary: CStack: Switching Windows port to using the C Loop LLINT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-18 11:26 PST by Mark Lam
Modified: 2014-01-22 17:58 PST (History)
8 users (show)

See Also:

Attachments
the patch. (19.31 KB, patch)
2014-01-18 11:45 PST, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-01-18 11:26:54 PST 
With the switch to using the C stack, the LLINT becomes a mandatory component for providing trampoline glue code to enter JIT code.  Since the Windows port does not currently have a LLINT implementation that can generate assembly code for Windows, we’ll switch the Windows port to using the C Loop LLINT.
Comment 1 Mark Lam 2014-01-18 11:45:03 PST 
Created attachment 221562 [details]
the patch.

This patch is not tested on a Windows build yet.  Will test before landing.
Comment 2 Geoffrey Garen 2014-01-18 12:37:04 PST 
Comment on attachment 221562 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=221562&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +        can generate assembly code for Windows, weâll switch the Windows port to

ASCII text for "we'll", please.
Comment 3 Mark Lam 2014-01-22 17:58:51 PST 
The patch builds on Windows.  Landed in r162577: <http://trac.webkit.org/r162577>.