Bug 12705 - REGRESSION: Crash with user stylesheet set
Summary: REGRESSION: Crash with user stylesheet set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2007-02-08 18:01 PST by Kevin M. Dean
Modified: 2007-02-12 21:01 PST (History)
2 users (show)

See Also:


Attachments
Crash log (55.26 KB, text/plain)
2007-02-08 18:01 PST, Kevin M. Dean
no flags Details
Patch (4.18 KB, patch)
2007-02-09 00:40 PST, Mark Rowe (bdash)
mjs: review+
Details | Formatted Diff | Diff
Updated patch (4.50 KB, patch)
2007-02-09 00:55 PST, Mark Rowe (bdash)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin M. Dean 2007-02-08 18:01:06 PST
crashes on initial load of nightly page
Comment 1 Kevin M. Dean 2007-02-08 18:01:35 PST
Created attachment 13075 [details]
Crash log
Comment 2 Matt Lilek 2007-02-08 18:09:54 PST
Confirmed with r19510 debug build.  Crashes when setting a stylesheet in the preferences as well.
Comment 3 Mark Rowe (bdash) 2007-02-08 18:35:00 PST
This is in radar as <rdar://problem/4986213> REGRESSION: Crash on page load when using user stylesheet.

The contents of the user stylesheet do not matter (I tested with an empty file), and the crash does not occur when loading file:/// URLs.
Comment 4 Mark Rowe (bdash) 2007-02-09 00:40:40 PST
Created attachment 13080 [details]
Patch
Comment 5 Maciej Stachowiak 2007-02-09 00:43:50 PST
Comment on attachment 13080 [details]
Patch


I would have made a special requestUserStyleSheet call w/ maybe a common method with the bool as private, but seems ok this way too

r=me either way
Comment 6 Mark Rowe (bdash) 2007-02-09 00:55:25 PST
Created attachment 13081 [details]
Updated patch

Use a new requestUserCSSStyleSheet method rather than a mysterious boolean.
Comment 7 Maciej Stachowiak 2007-02-09 00:58:02 PST
Comment on attachment 13081 [details]
Updated patch

r=me
Comment 8 Mark Rowe (bdash) 2007-02-09 01:00:59 PST
Fixed in r19524.
Comment 9 Kevin M. Dean 2007-02-12 18:17:28 PST
Crashing is back with r19583
Comment 10 Kevin M. Dean 2007-02-12 21:01:51 PST
r19593 is now working again