Bug 126774 - Remove unused error.h header.
Summary: Remove unused error.h header.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 128598
  Show dependency treegraph
 
Reported: 2014-01-10 13:10 PST by Koop Mast
Modified: 2014-02-24 07:00 PST (History)
2 users (show)

See Also:


Attachments
Remove unused error.h header (2.03 KB, patch)
2014-01-10 13:12 PST, Koop Mast
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Koop Mast 2014-01-10 13:10:03 PST
This header doesn't exists on FreeBSD.

According to https://www.gnu.org/software/gnulib/manual/html_node/error_002eh.html the function that this header implements are not present in the file. So there isn't any need for this header.
Comment 1 Koop Mast 2014-01-10 13:12:02 PST
Created attachment 220879 [details]
Remove unused error.h header
Comment 2 Koop Mast 2014-01-15 10:54:10 PST
Comment on attachment 220879 [details]
Remove unused error.h header

set review flag
Comment 3 Landry Breuil 2014-02-17 11:41:15 PST
Fwiw i have the same issue on OpenBSD when trying to update our webkit from 2.2.4 to 2.3.5 - removing the inclusion of error.h fixes the build breakage.
Comment 4 Alberto Garcia 2014-02-24 07:00:59 PST
Committed r164583: <http://trac.webkit.org/changeset/164583>