Bug 126506 - [JS] Implement Promise.race()
Summary: [JS] Implement Promise.race()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-05 14:56 PST by Sam Weinig
Modified: 2014-01-05 20:14 PST (History)
2 users (show)

See Also:

Attachments
Patch (11.17 KB, patch)
2014-01-05 15:00 PST, Sam Weinig 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-01-05 14:56:57 PST 
[JS] Implement Promise.race()
Comment 1 Sam Weinig 2014-01-05 15:00:45 PST 
Created attachment 220404 [details]
Patch
Comment 2 Oliver Hunt 2014-01-05 19:42:23 PST 
Comment on attachment 220404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220404&action=review

> Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp:383
> +        if (JSValue::strictEqual(exec, next, vm.iterationTerminator.get()))

should just do a value compare here
Comment 3 Sam Weinig 2014-01-05 20:14:44 PST 
Committed r161330: <http://trac.webkit.org/changeset/161330>