Bug 126490 - JSPromiseReaction.cpp should use Compiler macros instead of raw "final" and "override"
Summary: JSPromiseReaction.cpp should use Compiler macros instead of raw "final" and "...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-04 08:33 PST by Yusuke Suzuki
Modified: 2014-01-04 18:11 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2014-01-04 08:41 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2014-01-04 08:33:16 PST 
Since JSPromiseReaction.cpp use raw "final" and "override" macros, JSC cannot be built on Ubuntu 12.04's default compiler (g++ (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3)
Comment 1 Yusuke Suzuki 2014-01-04 08:33:31 PST 
I'll submit a patch soon.
Comment 2 Yusuke Suzuki 2014-01-04 08:41:47 PST 
Created attachment 220375 [details]
Patch
Comment 3 Yusuke Suzuki 2014-01-04 10:45:34 PST 
Thank you for your quick review, Sam! Could you set cq+?
Comment 4 Sam Weinig 2014-01-04 17:43:57 PST 
(In reply to comment #3)
> Thank you for your quick review, Sam! Could you set cq+?

Done.
Comment 5 WebKit Commit Bot 2014-01-04 18:11:34 PST 
Comment on attachment 220375 [details]
Patch

Clearing flags on attachment: 220375

Committed r161317: <http://trac.webkit.org/changeset/161317>
Comment 6 WebKit Commit Bot 2014-01-04 18:11:37 PST 
All reviewed patches have been landed.  Closing bug.