Bug 126453 - [GTK] [CMake] Improve the way that translations are built with the built-in gettext support CMake
Summary: [GTK] [CMake] Improve the way that translations are built with the built-in g...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 116379
  Show dependency tree / graph
 
Reported: 2014-01-03 12:54 PST by Martin Robinson
Modified: 2014-01-06 13:48 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.48 KB, patch)
2014-01-03 12:56 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-01-03 12:54:01 PST 
CMake has some very handy built-in support for gettext that can simplify our build and automatically take care of installation.
Comment 1 Martin Robinson 2014-01-03 12:56:36 PST 
Created attachment 220329 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2014-01-06 13:45:17 PST 
Comment on attachment 220329 [details]
Patch

hah, nice; I don't think we want po files to be update automatically, it often triggered issues with merge conflicts and buildbots would break
Comment 3 Martin Robinson 2014-01-06 13:48:43 PST 
Comment on attachment 220329 [details]
Patch

Clearing flags on attachment: 220329

Committed r161370: <http://trac.webkit.org/changeset/161370>
Comment 4 Martin Robinson 2014-01-06 13:48:46 PST 
All reviewed patches have been landed.  Closing bug.