Bug 126441 - [CSS Shapes] Reuse contentBoxRect(), paddingBoxRect(), borderBoxRect() functions from RenderBox?
Summary: [CSS Shapes] Reuse contentBoxRect(), paddingBoxRect(), borderBoxRect() functi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 98664
  Show dependency treegraph
Reported: 2014-01-03 10:55 PST by Dirk Schulze
Modified: 2014-02-24 14:31 PST (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2014-01-03 10:55:10 PST
It seems like ShapeInfo recalculates the the values necessary to determine the content-box, padding-box or border-box. Shapes maybe should use the functions contentBoxRect(), paddingBoxRect(), borderBoxRect() from RenderBox?
Comment 1 Bem Jones-Bey 2014-02-24 14:31:47 PST
In looking at it, I don't think there's a reasonable way to do this, because those rects are in physical coordinates, and we not only need to adjust for writing mode, we need to adjust for writing direction to determine the offset to use. Strictly speaking, we could use just the size portion of those rects and then transpose as needed, but I think that would be more confusing than not. (For examples, take a look at how ShapeInfo::logicalTopOffset and ShapeInfo::logicalLeftOffset are computed.)