Bug 126145 - [CMake] Fix typo from r160812
Summary: [CMake] Fix typo from r160812
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-22 20:29 PST by Martin Robinson
Modified: 2013-12-23 06:43 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2013-12-22 20:30 PST, Martin Robinson
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-12-22 20:29:37 PST
In r160812, JavaScriptCore_LIBRARY_TYPE is check against the string "SHARED_LIBRARY," but should be check against "SHARED." This prevents proper library versioning and installation.
Comment 1 Martin Robinson 2013-12-22 20:30:51 PST
Created attachment 219890 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-12-23 05:31:22 PST
Comment on attachment 219890 [details]
Patch

Oops =)
Comment 3 Martin Robinson 2013-12-23 06:43:27 PST
Committed r160995: <http://trac.webkit.org/changeset/160995>