Steps to reproduce: reload the attached document several times. The window title will be blank, or will display garbage intermittently. The is a regression from shipping WebKit, where the file name is used as window title.
Created attachment 12916 [details] test case
<rdar://problem/4975135>
Similar/related to Bug 3905.
Does this affect real-world sites?
> Does this affect real-world sites? I am not aware of any such sites. Discovered by accident when making a test case for another bug.
Created attachment 13012 [details] proposed fix
Comment on attachment 13012 [details] proposed fix How does this patch help? It looks to me like if i == length then the for loop won't do anything, the while loop won't do anything, and the following if statement will return "" anyway. So this patch would have no effect.
Comment on attachment 13012 [details] proposed fix In this case, the if statement doesn't return "": (!builderIndex && stringBuilder[builderIndex] == ' ') is false when stringBuilder[0] equals '\n', for example.
Comment on attachment 13012 [details] proposed fix OK. I'm convinced this is correct. Let me note in passing that I'm unhappy with the structure and readability of the function. It took me a really long time studying the code to understand why it's OK to look at stringBuilder[builderIndex] when builderIndex is 0, even though that's "off the end of the array".
Committed revision 19473.