Bug 125705 - Cleanup CodeGeneratorInspectorStrings a bit
Summary: Cleanup CodeGeneratorInspectorStrings a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-13 13:09 PST by Joseph Pecoraro
Modified: 2013-12-13 13:54 PST (History)
2 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (3.27 KB, patch)
2013-12-13 13:11 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-12-13 13:09:33 PST
• Always use ${foo} syntax
• Add an ASCIILiteral in one place for TypeBuilder output
Comment 1 Joseph Pecoraro 2013-12-13 13:11:02 PST
Created attachment 219189 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2013-12-13 13:53:50 PST
The commit-queue encountered the following flaky tests while processing attachment 219189 [details]:

svg/batik/filters/filterRegions.svg bug 116330 (authors: darin@apple.com, reni@webkit.org, and zimmermann@kde.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2013-12-13 13:54:27 PST
Comment on attachment 219189 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 219189

Committed r160565: <http://trac.webkit.org/changeset/160565>
Comment 4 WebKit Commit Bot 2013-12-13 13:54:29 PST
All reviewed patches have been landed.  Closing bug.