Bug 125612 - [Cocoa] Navigation action information for policy decisions is missing the original request
Summary: [Cocoa] Navigation action information for policy decisions is missing the ori...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-12-11 18:33 PST by mitz
Modified: 2013-12-12 10:42 PST (History)
2 users (show)

See Also:

Attachments
Expose the original request in the action dictionary (25.14 KB, patch)
2013-12-11 18:38 PST, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-12-11 18:33:13 PST 
[Cocoa] Navigation action information for policy decisions is missing the original request
Comment 1 mitz 2013-12-11 18:38:33 PST 
Created attachment 219029 [details]
Expose the original request in the action dictionary
Comment 2 WebKit Commit Bot 2013-12-11 18:40:18 PST 
Attachment 219029 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/HandleMessage.h', u'Source/WebKit2/UIProcess/API/C/WKPagePolicyClientInternal.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/WebPolicyClient.cpp', u'Source/WebKit2/UIProcess/WebPolicyClient.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:901:  The parameter name "request" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:36:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2013-12-11 18:41:18 PST 
Not sure if this internal interface is a good idea. The idea is that we won’t have to create a new versioned interface each time we modify something for the Cocoa API. We’ll only create a new version when the C API requires it (by moving the internal version to the main header).
Comment 4 mitz 2013-12-11 21:20:16 PST 
<rdar://problem/15644024>
Comment 5 mitz 2013-12-12 10:42:58 PST 
Fixed in <http://trac.webkit.org/r160495>.