Bug 125466 - Remove miscellaneous unnecessary build statements
Summary: Remove miscellaneous unnecessary build statements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-09 12:59 PST by Joseph Pecoraro
Modified: 2013-12-09 15:24 PST (History)
2 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (3.79 KB, patch)
2013-12-09 13:00 PST, Joseph Pecoraro
darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
[PATCH] With Adjustments (3.90 KB, patch)
2013-12-09 14:35 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-12-09 12:59:40 PST
• We no longer have a DerivedSources/JavaScriptCore/docs directory.
• WebCore is not accessed from within JavaScriptCore build scripts. Also, if it did that would probably be a problem for mac B&I builds, so remove this misleading line.
Comment 1 Joseph Pecoraro 2013-12-09 13:00:36 PST
Created attachment 218792 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2013-12-09 13:45:13 PST
Comment on attachment 218792 [details]
[PATCH] Proposed Fix

Attachment 218792 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/47218204
Comment 3 Joseph Pecoraro 2013-12-09 14:08:56 PST
Interesting! Apparently I need to keep the `mkdir -p` but just "JavaScriptCore/DerivedSources" not "/home/buildbot/WebKit/WEBKIT~2/Release/obj32/JavaScriptCore/DerivedSources/docs".
Comment 4 Joseph Pecoraro 2013-12-09 14:35:11 PST
Created attachment 218802 [details]
[PATCH] With Adjustments
Comment 5 WebKit Commit Bot 2013-12-09 15:24:18 PST
Comment on attachment 218802 [details]
[PATCH] With Adjustments

Clearing flags on attachment: 218802

Committed r160334: <http://trac.webkit.org/changeset/160334>
Comment 6 WebKit Commit Bot 2013-12-09 15:24:20 PST
All reviewed patches have been landed.  Closing bug.