Bug 125266 - [Cocoa] Make WKConnection work with WKObject wrapping
Summary: [Cocoa] Make WKConnection work with WKObject wrapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-04 16:57 PST by Sam Weinig
Modified: 2013-12-04 17:40 PST (History)
1 user (show)

See Also:

Attachments
Patch (9.41 KB, patch)
2013-12-04 16:58 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-12-04 16:57:45 PST 
[Cocoa] Make WKConnection work with WKObject wrapping
Comment 1 Sam Weinig 2013-12-04 16:58:02 PST 
Created attachment 218471 [details]
Patch
Comment 2 mitz 2013-12-04 17:02:08 PST 
Comment on attachment 218471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218471&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKConnection.mm:111
> +        _remoteObjectRegistry = adoptNS([[WKRemoteObjectRegistry alloc] _initWithConnectionRef:toAPI(_connection.get())]);

We should change the internal WKRemoteObjectRegistry initializer to take a WebConnection&.
Comment 3 Sam Weinig 2013-12-04 17:40:55 PST 
Committed r160148: <http://trac.webkit.org/changeset/160148>