Bug 125094 - [Nix] Add other UIProcess files
Summary: [Nix] Add other UIProcess files
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 117660
  Show dependency treegraph
 
Reported: 2013-12-02 13:36 PST by Lauro Moura Maranhao Neto
Modified: 2014-01-16 12:43 PST (History)
1 user (show)

See Also:


Attachments
Add other UIProcess files (49.84 KB, patch)
2013-12-12 12:09 PST, Daker Fernandes Pinheiro
no flags Details | Formatted Diff | Diff
Fix style (49.78 KB, patch)
2013-12-15 13:20 PST, Daker Fernandes Pinheiro
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura Maranhao Neto 2013-12-02 13:36:00 PST
Upstream other Nix UIProcess files.
Comment 1 Daker Fernandes Pinheiro 2013-12-12 12:09:52 PST
Created attachment 219107 [details]
Add other UIProcess files
Comment 2 WebKit Commit Bot 2013-12-12 12:11:12 PST
Attachment 219107 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/nix/TextCheckerNix.cpp', u'Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h', u'Source/WebKit2/UIProcess/nix/WebContextNix.cpp', u'Source/WebKit2/UIProcess/nix/WebInspectorProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPopupMenuListenerNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPopupMenuListenerNix.h', u'Source/WebKit2/UIProcess/nix/WebProcessProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewClientNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewClientNix.h', u'Source/WebKit2/UIProcess/nix/WebViewNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewNix.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.cpp:71:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.cpp:72:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:34:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:39:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:46:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:47:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:49:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.cpp:49:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/nix/TextCheckerNix.cpp:132:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
ERROR: Source/WebKit2/UIProcess/nix/TextCheckerNix.cpp:132:  There was more than one newline at the end of the file.  [whitespace/ending_newline] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.h:32:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.h:50:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/nix/WebContextNix.cpp:29:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextNix.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:37:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:48:  The parameter name "viewClient" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:50:  The parameter name "point" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:93:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:93:  The parameter name "pageGroup" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 26 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daker Fernandes Pinheiro 2013-12-15 13:20:49 PST
Created attachment 219280 [details]
Fix style
Comment 4 WebKit Commit Bot 2013-12-16 05:29:04 PST
Attachment 219280 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/nix/TextCheckerNix.cpp', u'Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h', u'Source/WebKit2/UIProcess/nix/WebContextNix.cpp', u'Source/WebKit2/UIProcess/nix/WebInspectorProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPopupMenuListenerNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPopupMenuListenerNix.h', u'Source/WebKit2/UIProcess/nix/WebProcessProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewClientNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewClientNix.h', u'Source/WebKit2/UIProcess/nix/WebViewNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewNix.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.cpp:73:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp:33:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextNix.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 6 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2013-12-20 17:19:20 PST
Comment on attachment 219280 [details]
Fix style

Attachment 219280 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/48638318
Comment 6 Lauro Moura Maranhao Neto 2014-01-16 12:43:23 PST
Marking as invalid due to Nix upstream halting.