Implemented missing HTML5 validation messages.
Created attachment 218044 [details] Proposed patch
Comment on attachment 218044 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=218044&action=review The change affects fast/forms/validationMessage.html. > Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:753 > + return String::fromUTF8(_("Value must be greater than or equal to ")) + minimum; This doesn't look a correct formatting way for l10n strings. This can't be translated to some languages. You should use g_strdup_printf() like imageTitle() in LocalizedStringsGtk,cpp, right?
Created attachment 218165 [details] Proposed patch in trunk/LayoutTests/platform/gtk/fast/forms/validation-message-appearance-expected.txt in line 27 "value missing" should be "Please fill out this field." but unfortunately I currently don't have a working build, so I didn't know the correct pixel size and just left it unchanged.
Comment on attachment 218165 [details] Proposed patch I have no additional comments. Please ask GTK reviewers to approve this.
Comment on attachment 218165 [details] Proposed patch Sorry for the late review. Thanks for working on this. This patch looks good, except new translatable strings really need to have translator comments. Please leave a comment on the line above each new string, to help translators figure out what the string is for. For example: // Translators: Displayed when required form field is left empty. return String::fromUTF8(_("Please fill out this field.")); We ought to add comments for the other strings in this file as well, but for now let's just worry about not introducing new strings that lack comments.
(In reply to comment #5) > Comment on attachment 218165 [details] > Proposed patch > > Sorry for the late review. Thanks for working on this. This patch looks > good, except new translatable strings really need to have translator > comments. Please leave a comment on the line above each new string, to help > translators figure out what the string is for. For example: > > // Translators: Displayed when required form field is left empty. > return String::fromUTF8(_("Please fill out this field.")); > > We ought to add comments for the other strings in this file as well, but for > now let's just worry about not introducing new strings that lack comments. Hi! Sorry, but I don't work on this project anymore.
(In reply to comment #6) > (In reply to comment #5) > > Comment on attachment 218165 [details] > > Proposed patch > > > > Sorry for the late review. Thanks for working on this. This patch looks > > good, except new translatable strings really need to have translator > > comments. Please leave a comment on the line above each new string, to help > > translators figure out what the string is for. For example: > > > > // Translators: Displayed when required form field is left empty. > > return String::fromUTF8(_("Please fill out this field.")); > > > > We ought to add comments for the other strings in this file as well, but for > > now let's just worry about not introducing new strings that lack comments. > > Hi! > > Sorry, but I don't work on this project anymore. Hey. Is this still worked on? Do you need help implementing these comments? I'd really like to see webkit give feedback to users when validating form fields with the HTML5 required attribute. What could I do to help? Holger