Bug 124993 - [EFL] PageViewportController does not need to be unique_ptr instance
Summary: [EFL] PageViewportController does not need to be unique_ptr instance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-28 17:59 PST by Ryuan Choi
Modified: 2013-11-28 19:39 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.77 KB, patch)
2013-11-28 18:53 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (9.04 KB, patch)
2013-11-28 19:26 PST, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-11-28 17:59:22 PST
PageViewportController and PageViewportControllerEfl have same life cycle with EwkView.
So, we don't need to make them as unique_ptr instance.
Comment 1 Ryuan Choi 2013-11-28 18:53:49 PST
Created attachment 218030 [details]
Patch
Comment 2 Ryuan Choi 2013-11-28 19:26:48 PST
Created attachment 218031 [details]
Patch
Comment 3 Gyuyoung Kim 2013-11-28 19:34:13 PST
Comment on attachment 218031 [details]
Patch

Looks fine.
Comment 4 Ryuan Choi 2013-11-28 19:39:29 PST
Comment on attachment 218031 [details]
Patch

Clearing flags on attachment: 218031

Committed r159863: <http://trac.webkit.org/changeset/159863>
Comment 5 Ryuan Choi 2013-11-28 19:39:36 PST
All reviewed patches have been landed.  Closing bug.