Bug 124982 - Nix Upstream: Updating Platform files
Summary: Nix Upstream: Updating Platform files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on:
Blocks: 124950
  Show dependency tree / graph
 
Reported: 2013-11-28 10:36 PST by Thiago de Barros Lacerda
Modified: 2013-12-02 14:56 PST (History)
12 users (show)

See Also:

Attachments
Patch (23.28 KB, patch)
2013-11-28 10:40 PST, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2013-11-28 10:36:49 PST 
Just to sync our github repo files and the trunk, as part of the upstream process
Comment 1 Thiago de Barros Lacerda 2013-11-28 10:40:44 PST 
Created attachment 218014 [details]
Patch
Comment 2 Benjamin Poulain 2013-12-02 14:27:26 PST 
Comment on attachment 218014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218014&action=review

This is all Nix "Platform" layer. LGTM.

> Source/Platform/nix/public/MediaStream.h:67
> +    // Caller must delete the returned MediaStreamSource*

Probably a good idea to enforce this by returning a vector of smart pointers.
Comment 3 WebKit Commit Bot 2013-12-02 14:56:17 PST 
Comment on attachment 218014 [details]
Patch

Clearing flags on attachment: 218014

Committed r159971: <http://trac.webkit.org/changeset/159971>
Comment 4 WebKit Commit Bot 2013-12-02 14:56:20 PST 
All reviewed patches have been landed.  Closing bug.