WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 124982
Nix Upstream: Updating Platform files
https://bugs.webkit.org/show_bug.cgi?id=124982
Summary
Nix Upstream: Updating Platform files
Thiago de Barros Lacerda
Reported
2013-11-28 10:36:49 PST
Just to sync our github repo files and the trunk, as part of the upstream process
Attachments
Patch
(23.28 KB, patch)
2013-11-28 10:40 PST
,
Thiago de Barros Lacerda
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1
2013-11-28 10:40:44 PST
Created
attachment 218014
[details]
Patch
Benjamin Poulain
Comment 2
2013-12-02 14:27:26 PST
Comment on
attachment 218014
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=218014&action=review
This is all Nix "Platform" layer. LGTM.
> Source/Platform/nix/public/MediaStream.h:67 > + // Caller must delete the returned MediaStreamSource*
Probably a good idea to enforce this by returning a vector of smart pointers.
WebKit Commit Bot
Comment 3
2013-12-02 14:56:17 PST
Comment on
attachment 218014
[details]
Patch Clearing flags on attachment: 218014 Committed
r159971
: <
http://trac.webkit.org/changeset/159971
>
WebKit Commit Bot
Comment 4
2013-12-02 14:56:20 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug