Bug 124696 - Clean up WebKit2 initialization
Summary: Clean up WebKit2 initialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-20 18:19 PST by Simon Fraser (smfr)
Modified: 2013-11-21 10:18 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.22 KB, patch)
2013-11-20 18:21 PST, Simon Fraser (smfr) 		sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-11-20 18:19:14 PST 
Clean up WebKit2 initialization
Comment 1 Simon Fraser (smfr) 2013-11-20 18:21:09 PST 
Created attachment 217510 [details]
Patch
Comment 2 Build Bot 2013-11-20 18:25:52 PST 
Comment on attachment 217510 [details]
Patch

Attachment 217510 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/31508033
Comment 3 Build Bot 2013-11-20 18:49:32 PST 
Comment on attachment 217510 [details]
Patch

Attachment 217510 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/32348002
Comment 4 Sam Weinig 2013-11-20 20:09:45 PST 
Comment on attachment 217510 [details]
Patch

Looks good, other than you are missing a few includes to make it build.
Comment 5 Simon Fraser (smfr) 2013-11-21 10:18:53 PST 
https://trac.webkit.org/r159634