Bug 124491 - [MIPS] Build fails since r159395.
Summary: [MIPS] Build fails since r159395.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-18 03:59 PST by Balazs Kilvady
Modified: 2013-11-18 08:55 PST (History)
8 users (show)

See Also:


Attachments
proposed patch. (2.19 KB, patch)
2013-11-18 07:55 PST, Balazs Kilvady
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kilvady 2013-11-18 03:59:17 PST
+++ This bug was initially created as a clone of Bug #121439 +++

/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1458:74: error: no matching function for call to 'JSC::DFG::JITCompiler::setupArgumentsWithExecState(JSC::DFG::SpeculativeJIT::TrustedImm32, JSC::DFG::FPRReg&, JSC::DFG::GPRReg&)'
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1564:80: error: no matching function for call to 'JSC::DFG::JITCompiler::setupArgumentsWithExecState(JSC::DFG::GPRReg&, JSC::DFG::GPRReg&, JSC::DFG::SpeculativeJIT::TrustedImm32, JSC::DFG::FPRReg&)'
Comment 1 Balazs Kilvady 2013-11-18 04:01:06 PST
Build fails on MIPS since http://trac.webkit.org/changeset/159395 because the following function is missing from MacroAssembler:

    Jump branch8(RelationalCondition cond, AbsoluteAddress left, TrustedImm32 right)
Comment 2 Balazs Kilvady 2013-11-18 07:55:21 PST
Created attachment 217198 [details]
proposed patch.
Comment 3 WebKit Commit Bot 2013-11-18 08:55:46 PST
Comment on attachment 217198 [details]
proposed patch.

Clearing flags on attachment: 217198

Committed r159425: <http://trac.webkit.org/changeset/159425>
Comment 4 WebKit Commit Bot 2013-11-18 08:55:48 PST
All reviewed patches have been landed.  Closing bug.