RESOLVED FIXED 124456
Mark classes deriving from SVGAnimatedTypeAnimator as FINAL 
https://bugs.webkit.org/show_bug.cgi?id=124456
Summary Mark classes deriving from SVGAnimatedTypeAnimator as FINAL
Sergio Correia (qrwteyrutiyoup)
Reported 2013-11-16 10:29:18 PST
Mark classes deriving from SVGAnimatedTypeAnimator as FINAL
Attachments
Patch (38.38 KB, patch)
2013-11-16 10:32 PST, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
Patch (38.37 KB, patch)
2013-11-19 10:08 PST, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Correia (qrwteyrutiyoup)
Comment 1 2013-11-16 10:30:48 PST
Also add OVERRIDE to their virtual methods appropriately and remove existing empty virtual destructors.
Sergio Correia (qrwteyrutiyoup)
Comment 2 2013-11-16 10:32:02 PST
Created attachment 217128 [details] Patch
Sergio Correia (qrwteyrutiyoup)
Comment 3 2013-11-16 10:33:50 PST
Comment on attachment 217128 [details] Patch Removing the r? flag for now, as this is based on top of https://bugs.webkit.org/show_bug.cgi?id=124382
Sergio Correia (qrwteyrutiyoup)
Comment 4 2013-11-19 10:08:42 PST
Created attachment 217310 [details] Patch
WebKit Commit Bot
Comment 5 2013-11-19 12:12:26 PST
Comment on attachment 217310 [details] Patch Clearing flags on attachment: 217310 Committed r159512: <http://trac.webkit.org/changeset/159512>
WebKit Commit Bot
Comment 6 2013-11-19 12:12:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.