Bug 124456 - Mark classes deriving from SVGAnimatedTypeAnimator as FINAL
Summary: Mark classes deriving from SVGAnimatedTypeAnimator as FINAL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Correia (qrwteyrutiyoup)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-16 10:29 PST by Sergio Correia (qrwteyrutiyoup)
Modified: 2013-11-19 12:12 PST (History)
8 users (show)

See Also:

Attachments
Patch (38.38 KB, patch)
2013-11-16 10:32 PST, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Patch (38.37 KB, patch)
2013-11-19 10:08 PST, Sergio Correia (qrwteyrutiyoup) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Correia (qrwteyrutiyoup) 2013-11-16 10:29:18 PST 
Mark classes deriving from SVGAnimatedTypeAnimator as FINAL
Comment 1 Sergio Correia (qrwteyrutiyoup) 2013-11-16 10:30:48 PST 
Also add OVERRIDE to their virtual methods appropriately and remove existing empty virtual destructors.
Comment 2 Sergio Correia (qrwteyrutiyoup) 2013-11-16 10:32:02 PST 
Created attachment 217128 [details]
Patch
Comment 3 Sergio Correia (qrwteyrutiyoup) 2013-11-16 10:33:50 PST 
Comment on attachment 217128 [details]
Patch

Removing the r? flag for now, as this is based on top of https://bugs.webkit.org/show_bug.cgi?id=124382
Comment 4 Sergio Correia (qrwteyrutiyoup) 2013-11-19 10:08:42 PST 
Created attachment 217310 [details]
Patch
Comment 5 WebKit Commit Bot 2013-11-19 12:12:26 PST 
Comment on attachment 217310 [details]
Patch

Clearing flags on attachment: 217310

Committed r159512: <http://trac.webkit.org/changeset/159512>
Comment 6 WebKit Commit Bot 2013-11-19 12:12:29 PST 
All reviewed patches have been landed.  Closing bug.