RESOLVED FIXED124256
Update ResourceHandleCF to use the didReceiveBuffer() callback 
https://bugs.webkit.org/show_bug.cgi?id=124256
Summary Update ResourceHandleCF to use the didReceiveBuffer() callback
Benjamin Poulain
Reported 2013-11-12 18:02:08 PST
Update ResourceHandleCF to use the didReceiveBuffer() callback
Attachments
Patch (3.24 KB, patch)
2013-11-12 18:04 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (3.30 KB, patch)
2013-11-12 19:16 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (33.34 KB, patch)
2013-12-02 21:09 PST, Benjamin Poulain 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-11-12 18:04:56 PST
Created attachment 216758 [details] Patch
Build Bot
Comment 2 2013-11-12 18:46:15 PST
Comment on attachment 216758 [details] Patch Attachment 216758 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/22888893
Benjamin Poulain
Comment 3 2013-11-12 19:16:53 PST
Created attachment 216764 [details] Patch
Benjamin Poulain
Comment 4 2013-11-13 14:04:25 PST
Comment on attachment 216764 [details] Patch Clearing flags on attachment: 216764 Committed r159235: <http://trac.webkit.org/changeset/159235>
Benjamin Poulain
Comment 5 2013-11-13 14:04:27 PST
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 6 2013-12-02 21:09:04 PST
Reopening to attach new patch.
Benjamin Poulain
Comment 7 2013-12-02 21:09:06 PST
Created attachment 218263 [details] Patch
Benjamin Poulain
Comment 8 2013-12-02 21:11:31 PST
Windows does not handle blocks, that sucks :(
WebKit Commit Bot
Comment 9 2013-12-02 21:11:33 PST
Attachment 218263 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/ResourceHandleClient.cpp', u'Source/WebCore/platform/network/ResourceHandleClient.h', u'Source/WebCore/platform/network/ResourceHandleInternal.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp']" exit_code: 1 ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:206: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:283: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:322: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:364: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:391: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:431: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:463: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:506: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:541: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:582: Missing space before { [whitespace/braces] [5] Total errors found: 10 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 10 2013-12-02 21:52:13 PST
Comment on attachment 218263 [details] Patch Attachment 218263 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/42058036
Note You need to log in before you can comment on or make changes to this bug.