Bug 124256 - Update ResourceHandleCF to use the didReceiveBuffer() callback
Summary: Update ResourceHandleCF to use the didReceiveBuffer() callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-12 18:02 PST by Benjamin Poulain
Modified: 2013-12-12 20:55 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2013-11-12 18:04 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (3.30 KB, patch)
2013-11-12 19:16 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (33.34 KB, patch)
2013-12-02 21:09 PST, Benjamin Poulain 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-11-12 18:02:08 PST 
Update ResourceHandleCF to use the didReceiveBuffer() callback
Comment 1 Benjamin Poulain 2013-11-12 18:04:56 PST 
Created attachment 216758 [details]
Patch
Comment 2 Build Bot 2013-11-12 18:46:15 PST 
Comment on attachment 216758 [details]
Patch

Attachment 216758 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/22888893
Comment 3 Benjamin Poulain 2013-11-12 19:16:53 PST 
Created attachment 216764 [details]
Patch
Comment 4 Benjamin Poulain 2013-11-13 14:04:25 PST 
Comment on attachment 216764 [details]
Patch

Clearing flags on attachment: 216764

Committed r159235: <http://trac.webkit.org/changeset/159235>
Comment 5 Benjamin Poulain 2013-11-13 14:04:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Benjamin Poulain 2013-12-02 21:09:04 PST 
Reopening to attach new patch.
Comment 7 Benjamin Poulain 2013-12-02 21:09:06 PST 
Created attachment 218263 [details]
Patch
Comment 8 Benjamin Poulain 2013-12-02 21:11:31 PST 
Windows does not handle blocks, that sucks :(
Comment 9 WebKit Commit Bot 2013-12-02 21:11:33 PST 
Attachment 218263 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/ResourceHandleClient.cpp', u'Source/WebCore/platform/network/ResourceHandleClient.h', u'Source/WebCore/platform/network/ResourceHandleInternal.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp']" exit_code: 1
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:206:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:283:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:322:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:364:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:391:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:431:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:463:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:506:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:541:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:582:  Missing space before {  [whitespace/braces] [5]
Total errors found: 10 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Build Bot 2013-12-02 21:52:13 PST 
Comment on attachment 218263 [details]
Patch

Attachment 218263 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/42058036