Bug 124099 - Move BindingSecurity stuff under JSDOMBinding umbrella.
Summary: Move BindingSecurity stuff under JSDOMBinding umbrella.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-11-08 22:18 PST by Andreas Kling
Modified: 2013-11-10 08:27 PST (History)
6 users (show)

See Also:

Patch (22.37 KB, patch)
2013-11-08 22:20 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-08 22:18:42 PST
BindingSecurity is an unnecessary abstraction that was used to support alternate JS engines in the past.
Today it is 100% overhead.
Comment 1 Andreas Kling 2013-11-08 22:20:27 PST
Created attachment 216482 [details]
Comment 2 WebKit Commit Bot 2013-11-08 22:23:00 PST
Attachment 216482 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/generic/BindingSecurity.h', u'Source/WebCore/bindings/js/JSDOMBinding.cpp', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMWindowBase.cpp', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptManager.cpp', u'Source/WebCore/bindings/objc/WebScriptObject.mm', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm']" exit_code: 1
Source/WebCore/bindings/js/JSDOMBinding.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2013-11-09 02:14:39 PST
Comment on attachment 216482 [details]

nice catch
Comment 4 WebKit Commit Bot 2013-11-09 03:14:40 PST
Comment on attachment 216482 [details]

Clearing flags on attachment: 216482

Committed r158997: <http://trac.webkit.org/changeset/158997>
Comment 5 WebKit Commit Bot 2013-11-09 03:14:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Fraser (smfr) 2013-11-10 08:27:12 PST
This broke bindings tests:

FAIL: (JS) JSTestActiveDOMObject.cpp
--- WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp	2013-10-29 16:18:07.000000000 -0700
+++ /var/folders/f2/msb27q8x1wn588l8jynt8z540000gn/T/tmpi_eV3Y/JSTestActiveDOMObject.cpp	2013-11-10 03:30:31.000000000 -0800
@@ -21,7 +21,6 @@
 #include "config.h"
 #include "JSTestActiveDOMObject.h"
-#include "BindingSecurity.h"
 #include "ExceptionCode.h"
 #include "JSDOMBinding.h"
 #include "JSNode.h"

Please watch the bots after landing!