Bug 124024 - InlineFlowBox always has a RenderBoxModelObject, take advantage.
Summary: InlineFlowBox always has a RenderBoxModelObject, take advantage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-07 18:03 PST by Andreas Kling
Modified: 2013-11-07 18:41 PST (History)
4 users (show)

See Also:

Attachments
Patch (15.59 KB, patch)
2013-11-07 18:04 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-07 18:03:48 PST 
InlineFlowBox always has a RenderBoxModelObject, take advantage.
Comment 1 Andreas Kling 2013-11-07 18:04:14 PST 
Created attachment 216348 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-07 18:05:15 PST 
Attachment 216348 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp']" exit_code: 1
Source/WebCore/rendering/InlineFlowBox.cpp:590:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2013-11-07 18:41:23 PST 
Comment on attachment 216348 [details]
Patch

Clearing flags on attachment: 216348

Committed r158894: <http://trac.webkit.org/changeset/158894>
Comment 4 WebKit Commit Bot 2013-11-07 18:41:24 PST 
All reviewed patches have been landed.  Closing bug.