Bug 123774 - AX: DRT AccessibilityUIElement::isFocused methods should be finished.
Summary: AX: DRT AccessibilityUIElement::isFocused methods should be finished.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.9
: P2 Normal
Assignee: Samuel White
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-04 17:40 PST by Samuel White
Modified: 2013-11-07 09:54 PST (History)
10 users (show)

See Also:

Attachments
Patch. (2.15 KB, patch)
2013-11-04 17:45 PST, Samuel White 		darin: review+
Details | Formatted Diff | Diff
Updated patch. (5.08 KB, patch)
2013-11-06 17:01 PST, Samuel White 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel White 2013-11-04 17:40:59 PST 
Currently FIXMEs. Should fill them out to help with test brevity.
Comment 1 Radar WebKit Bug Importer 2013-11-04 17:41:31 PST 
<rdar://problem/15389611>
Comment 2 Samuel White 2013-11-04 17:45:35 PST 
Created attachment 215979 [details]
Patch.
Comment 3 chris fleizach 2013-11-04 17:55:39 PST 
Comment on attachment 215979 [details]
Patch.

we should probably add a layout test for this one, just something simple that confirms it's working as expected. thanks
Comment 4 Darin Adler 2013-11-05 08:53:17 PST 
I agree, we need a regression test too. Maybe I should have said review- for lack of regression test.
Comment 5 Samuel White 2013-11-06 17:01:22 PST 
Created attachment 216244 [details]
Updated patch.
Comment 6 Samuel White 2013-11-06 17:03:02 PST 
(In reply to comment #4)
> I agree, we need a regression test too. Maybe I should have said review- for lack of regression test.

Added a blanket regression test for all our Mac platform convenience method expectations. Will open bug to fill in others if this approach is alright. Thanks.
Comment 7 WebKit Commit Bot 2013-11-07 09:54:07 PST 
Comment on attachment 216244 [details]
Updated patch.

Clearing flags on attachment: 216244

Committed r158852: <http://trac.webkit.org/changeset/158852>
Comment 8 WebKit Commit Bot 2013-11-07 09:54:09 PST 
All reviewed patches have been landed.  Closing bug.