WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123774
AX: DRT AccessibilityUIElement::isFocused methods should be finished.
https://bugs.webkit.org/show_bug.cgi?id=123774
Summary
AX: DRT AccessibilityUIElement::isFocused methods should be finished.
Samuel White
Reported
2013-11-04 17:40:59 PST
Currently FIXMEs. Should fill them out to help with test brevity.
Attachments
Patch.
(2.15 KB, patch)
2013-11-04 17:45 PST
,
Samuel White
darin
: review+
Details
Formatted Diff
Diff
Updated patch.
(5.08 KB, patch)
2013-11-06 17:01 PST
,
Samuel White
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-11-04 17:41:31 PST
<
rdar://problem/15389611
>
Samuel White
Comment 2
2013-11-04 17:45:35 PST
Created
attachment 215979
[details]
Patch.
chris fleizach
Comment 3
2013-11-04 17:55:39 PST
Comment on
attachment 215979
[details]
Patch. we should probably add a layout test for this one, just something simple that confirms it's working as expected. thanks
Darin Adler
Comment 4
2013-11-05 08:53:17 PST
I agree, we need a regression test too. Maybe I should have said review- for lack of regression test.
Samuel White
Comment 5
2013-11-06 17:01:22 PST
Created
attachment 216244
[details]
Updated patch.
Samuel White
Comment 6
2013-11-06 17:03:02 PST
(In reply to
comment #4
)
> I agree, we need a regression test too. Maybe I should have said review- for lack of regression test.
Added a blanket regression test for all our Mac platform convenience method expectations. Will open bug to fill in others if this approach is alright. Thanks.
WebKit Commit Bot
Comment 7
2013-11-07 09:54:07 PST
Comment on
attachment 216244
[details]
Updated patch. Clearing flags on attachment: 216244 Committed
r158852
: <
http://trac.webkit.org/changeset/158852
>
WebKit Commit Bot
Comment 8
2013-11-07 09:54:09 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug