Bug 123591 - FTL::Location::restoreInto() doesn't handle stack-related registers correctly if you're using it after pushing a new stack frame
Summary: FTL::Location::restoreInto() doesn't handle stack-related registers correctly...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency treegraph
 
Reported: 2013-10-31 14:24 PDT by Filip Pizlo
Modified: 2013-10-31 17:33 PDT (History)
8 users (show)

See Also:


Attachments
the patch (4.61 KB, patch)
2013-10-31 14:25 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (4.67 KB, patch)
2013-10-31 15:13 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-31 14:24:01 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2013-10-31 14:25:45 PDT
Created attachment 215678 [details]
the patch
Comment 2 Filip Pizlo 2013-10-31 15:13:09 PDT
Created attachment 215680 [details]
the patch
Comment 3 Mark Hahnenberg 2013-10-31 15:15:56 PDT
Comment on attachment 215680 [details]
the patch

r=me
Comment 4 Filip Pizlo 2013-10-31 17:33:48 PDT
Landed in http://trac.webkit.org/changeset/158400