Bug 123290 - Add level dependent size checks to textureImage2D calls
Summary: Add level dependent size checks to textureImage2D calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Roger Fong
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-24 14:06 PDT by Roger Fong
Modified: 2013-10-24 16:40 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.69 KB, patch)
2013-10-24 14:18 PDT, Roger Fong
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-10-24 14:06:21 PDT
<rdar://problem/15201382>

There are different size limits went calling textureImage2D on different levels of the texture.

conformance-suites/1.0.2/conformance/textures/texture-size-limit.html tests for this.
Comment 1 Roger Fong 2013-10-24 14:18:44 PDT
Created attachment 215104 [details]
Patch
Comment 2 Dean Jackson 2013-10-24 15:25:50 PDT
Comment on attachment 215104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215104&action=review

> LayoutTests/ChangeLog:25
> +2013-10-24  Roger Fong  <roger_fong@apple.com>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * platform/mac/TestExpectations:
> +
> +2013-10-24  Roger Fong  <roger_fong@apple.com>
> +
> +        Unreviewed gardening. Skip some failing WebGL Conformance suite 1.0.1 tests.
> +
> +        * platform/mac/TestExpectations:
> +

Oops!
Comment 3 Roger Fong 2013-10-24 16:40:47 PDT
Committed: http://trac.webkit.org/changeset/157959