Bug 123200 - [EFL] Skip tests which are already passed in WebKit1.
Summary: [EFL] Skip tests which are already passed in WebKit1.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 04:16 PDT by Sun-woo Nam
Modified: 2013-10-23 21:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2013-10-23 05:00 PDT, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Patch (2.85 KB, patch)
2013-10-23 18:32 PDT, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2013-10-23 18:35 PDT, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Patch (2.93 KB, patch)
2013-10-23 19:27 PDT, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Patch (3.01 KB, patch)
2013-10-23 20:20 PDT, Sun-woo Nam 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sun-woo Nam 2013-10-23 04:16:43 PDT 
fast/media/view-mode-media-feature.html
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html 
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html 
fast/media/media-query-list-06.html 

Move the tests that only fail in wk2 to their file, and unskip the ones that are passing in all cases.
Comment 1 Sun-woo Nam 2013-10-23 05:00:44 PDT 
Created attachment 214944 [details]
Patch
Comment 2 Gyuyoung Kim 2013-10-23 17:54:11 PDT 
Comment on attachment 214944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214944&action=review

Please keep patch based on latest trunk.

> LayoutTests/ChangeLog:2
> +

Unneeded line.

> LayoutTests/ChangeLog:4
> +        Unskip tests which are already passed in WebKit1.

Please add [EFL] prefix for EFL specific patch.
Comment 3 Sun-woo Nam 2013-10-23 18:32:05 PDT 
Created attachment 215019 [details]
Patch
Comment 4 Sun-woo Nam 2013-10-23 18:35:19 PDT 
Created attachment 215020 [details]
Patch
Comment 5 Gyuyoung Kim 2013-10-23 18:57:14 PDT 
Comment on attachment 215020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215020&action=review

> LayoutTests/ChangeLog:3
> +        [EFL]Unskip tests which are already passed in WebKit1.

Add a space between [EFL] and Unskip. And also, sync with this bug title with changed title.

> LayoutTests/ChangeLog:7
> +

Missing patch description. Please mention why you can unskip those tests.
Comment 6 Gyuyoung Kim 2013-10-23 19:00:40 PDT 
Comment on attachment 215020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215020&action=review

> LayoutTests/platform/efl-wk2/TestExpectations:386
> +# WKTR / EFL's DRT do not support setViewModeMediaFeature().

Remove *EFL's DRT* in comment.
Comment 7 Sun-woo Nam 2013-10-23 19:27:07 PDT 
Created attachment 215023 [details]
Patch
Comment 8 Sun-woo Nam 2013-10-23 20:20:09 PDT 
Created attachment 215024 [details]
Patch
Comment 9 WebKit Commit Bot 2013-10-23 21:07:22 PDT 
Comment on attachment 215024 [details]
Patch

Clearing flags on attachment: 215024

Committed r157910: <http://trac.webkit.org/changeset/157910>
Comment 10 WebKit Commit Bot 2013-10-23 21:07:25 PDT 
All reviewed patches have been landed.  Closing bug.