Bug 123116 - Remote Layer Tree: Clean up transaction logging
Summary: Remote Layer Tree: Clean up transaction logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 13:15 PDT by Tim Horton
Modified: 2013-10-21 13:40 PDT (History)
2 users (show)

See Also:


Attachments
patch (25.21 KB, patch)
2013-10-21 13:20 PDT, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-21 13:15:53 PDT
Lots of duplicated code, lots of ugly things.
Comment 1 Tim Horton 2013-10-21 13:20:26 PDT
Created attachment 214770 [details]
patch
Comment 2 Anders Carlsson 2013-10-21 13:36:05 PDT
Comment on attachment 214770 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214770&action=review

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:426
> +RemoteLayerTreeTextStream& RemoteLayerTreeTextStream::operator<<(const FloatRect rect)

No need for const here.
Comment 3 Tim Horton 2013-10-21 13:40:38 PDT
http://trac.webkit.org/changeset/157731