Bug 122909 - Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
Summary: Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 122677
  Show dependency tree / graph
 
Reported: 2013-10-16 11:58 PDT by Alexey Proskuryakov
Modified: 2013-11-18 11:32 PST (History)
3 users (show)

See Also:

Attachments
screenshot (148.89 KB, image/png)
2013-10-16 11:58 PDT, Alexey Proskuryakov 		no flags Details
patch (3.08 KB, patch)
2013-11-16 14:37 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (1.80 KB, patch)
2013-11-18 00:56 PST, Tim Horton 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-16 11:58:05 PDT 
Created attachment 214382 [details]
screenshot

Especially with checkmarks, this looks fairly bad.

I think that there are two issues:
- the font is different, making the checkmark look like it's lower;
- numbers look good when zoomed in, so it's probably some rounding in layout.
Comment 1 Tim Horton 2013-11-16 14:37:20 PST 
Created attachment 217135 [details]
patch
Comment 2 WebKit Commit Bot 2013-11-16 15:17:09 PST 
Comment on attachment 217135 [details]
patch

Clearing flags on attachment: 217135

Committed r159382: <http://trac.webkit.org/changeset/159382>
Comment 3 WebKit Commit Bot 2013-11-16 15:17:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Tim Horton 2013-11-18 00:55:59 PST 
Reopening for a follow up patch. This can look terrible sometimes when the SVG doesn't load until after the bot data is all loaded... let's data-uri it.
Comment 5 Tim Horton 2013-11-18 00:56:13 PST 
Created attachment 217176 [details]
patch
Comment 6 Alexey Proskuryakov 2013-11-18 08:35:12 PST 
Comment on attachment 217176 [details]
patch

Should this patch also delete the SVG file?
Comment 7 Tim Horton 2013-11-18 11:30:08 PST 
(In reply to comment #6)
> (From update of attachment 217176 [details])
> Should this patch also delete the SVG file?

I suppose, since it's trivially recoverable from the data URI.
Comment 8 Tim Horton 2013-11-18 11:32:19 PST 
http://trac.webkit.org/changeset/159440