Bug 122778 - Add an empty window.crypto.webkitSubtle
Summary: Add an empty window.crypto.webkitSubtle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 122679
  Show dependency treegraph
 
Reported: 2013-10-14 14:34 PDT by Alexey Proskuryakov
Modified: 2013-10-14 16:35 PDT (History)
14 users (show)

See Also:


Attachments
proposed patch (30.09 KB, patch)
2013-10-14 14:40 PDT, Alexey Proskuryakov
mhahnenberg: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch for EWS (33.43 KB, patch)
2013-10-14 15:33 PDT, Alexey Proskuryakov
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch for landing (32.76 KB, patch)
2013-10-14 16:09 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-14 14:34:55 PDT
Adding a new property is surprisingly difficult if you are trying to get garbage collection behavior right.
Comment 1 Alexey Proskuryakov 2013-10-14 14:40:45 PDT
Created attachment 214190 [details]
proposed patch
Comment 2 EFL EWS Bot 2013-10-14 14:46:14 PDT
Comment on attachment 214190 [details]
proposed patch

Attachment 214190 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3945864
Comment 3 EFL EWS Bot 2013-10-14 14:47:08 PDT
Comment on attachment 214190 [details]
proposed patch

Attachment 214190 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3946927
Comment 4 Mark Hahnenberg 2013-10-14 14:54:18 PDT
Comment on attachment 214190 [details]
proposed patch

r=me with build happiness
Comment 5 Alexey Proskuryakov 2013-10-14 15:33:19 PDT
Created attachment 214196 [details]
patch for EWS
Comment 6 Alexey Proskuryakov 2013-10-14 16:05:34 PDT
Windows build failed, but it's doesn't appear to be because of this patch.
Comment 7 WebKit Commit Bot 2013-10-14 16:07:50 PDT
Comment on attachment 214196 [details]
patch for EWS

Rejecting attachment 214196 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 214196, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/3951874
Comment 8 Alexey Proskuryakov 2013-10-14 16:09:37 PDT
Created attachment 214203 [details]
patch for landing
Comment 9 WebKit Commit Bot 2013-10-14 16:35:01 PDT
Comment on attachment 214203 [details]
patch for landing

Clearing flags on attachment: 214203

Committed r157430: <http://trac.webkit.org/changeset/157430>
Comment 10 WebKit Commit Bot 2013-10-14 16:35:04 PDT
All reviewed patches have been landed.  Closing bug.