RESOLVED FIXED 122778
Add an empty window.crypto.webkitSubtle 
https://bugs.webkit.org/show_bug.cgi?id=122778
Summary Add an empty window.crypto.webkitSubtle
Alexey Proskuryakov
Reported 2013-10-14 14:34:55 PDT
Adding a new property is surprisingly difficult if you are trying to get garbage collection behavior right.
Attachments
proposed patch (30.09 KB, patch)
2013-10-14 14:40 PDT, Alexey Proskuryakov 		mhahnenberg: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
patch for EWS (33.43 KB, patch)
2013-10-14 15:33 PDT, Alexey Proskuryakov 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
patch for landing (32.76 KB, patch)
2013-10-14 16:09 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-14 14:40:45 PDT
Created attachment 214190 [details] proposed patch
EFL EWS Bot
Comment 2 2013-10-14 14:46:14 PDT
Comment on attachment 214190 [details] proposed patch Attachment 214190 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3945864
EFL EWS Bot
Comment 3 2013-10-14 14:47:08 PDT
Comment on attachment 214190 [details] proposed patch Attachment 214190 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3946927
Mark Hahnenberg
Comment 4 2013-10-14 14:54:18 PDT
Comment on attachment 214190 [details] proposed patch r=me with build happiness
Alexey Proskuryakov
Comment 5 2013-10-14 15:33:19 PDT
Created attachment 214196 [details] patch for EWS
Alexey Proskuryakov
Comment 6 2013-10-14 16:05:34 PDT
Windows build failed, but it's doesn't appear to be because of this patch.
WebKit Commit Bot
Comment 7 2013-10-14 16:07:50 PDT
Comment on attachment 214196 [details] patch for EWS Rejecting attachment 214196 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 214196, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/3951874
Alexey Proskuryakov
Comment 8 2013-10-14 16:09:37 PDT
Created attachment 214203 [details] patch for landing
WebKit Commit Bot
Comment 9 2013-10-14 16:35:01 PDT
Comment on attachment 214203 [details] patch for landing Clearing flags on attachment: 214203 Committed r157430: <http://trac.webkit.org/changeset/157430>
WebKit Commit Bot
Comment 10 2013-10-14 16:35:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.