122767 – Remove some silly null checks in Element/NamedNodeMap.

Bug 122767 - Remove some silly null checks in Element/NamedNodeMap.

Summary: Remove some silly null checks in Element/NamedNodeMap.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	DOM (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andreas Kling

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-10-14 11:26 PDT by Andreas Kling
Modified:	2019-02-06 09:03 PST (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (6.30 KB, patch) 2013-10-14 11:35 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Kling 2013-10-14 11:26:09 PDT

Remove some silly 'this' null checks in Element.cpp

Comment 1 Andreas Kling 2013-10-14 11:35:41 PDT

Created attachment 214170 [details]
Patch

Comment 2 WebKit Commit Bot 2013-10-14 12:22:38 PDT

Comment on attachment 214170 [details]
Patch

Clearing flags on attachment: 214170

Committed r157412: <http://trac.webkit.org/changeset/157412>

Comment 3 WebKit Commit Bot 2013-10-14 12:22:40 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Ryosuke Niwa 2013-10-15 11:10:38 PDT

This patch may have improved Dromaeo/jslib-event-jquery's score by ~28%

https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-lion%22%2C%22Dromaeo%2Fjslib-event-jquery%3ARuns%22%5D%2C%5B%22mac-mountainlion%22%2C%22Dromaeo%2Fjslib-event-jquery%3ARuns%22%5D%2C%5B%22mac-mountainlion%22%2C%22Dromaeo%2Fjslib-event-prototype%3ARuns%22%5D%2C%5B%22mac-lion%22%2C%22Dromaeo%2Fjslib-event-prototype%3ARuns%22%5D%5D&days=52&zoom=%5B1381585431357.5227%2C1381827392596%5D

Comment 5 Lucas Forschler 2019-02-06 09:03:52 PST

Mass moving XML DOM bugs to the "DOM" Component.