Bug 122464 - Animated images are not restarted when page visibility changes
Summary: Animated images are not restarted when page visibility changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-07 12:36 PDT by Tim Horton
Modified: 2013-10-07 13:26 PDT (History)
2 users (show)

See Also:

Attachments
patch (8.02 KB, patch)
2013-10-07 12:55 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-07 12:36:11 PDT 
Currently, animated images are kickstarted when a frame moves into the window, but not when the frame just becomes visible. We need to do it in both cases.

<rdar://problem/14293474>
Comment 1 Tim Horton 2013-10-07 12:55:13 PDT 
Created attachment 213613 [details]
patch
Comment 2 Simon Fraser (smfr) 2013-10-07 12:58:23 PDT 
Comment on attachment 213613 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213613&action=review

> Source/WebCore/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests; attempts to make a test have resulted only in a flaky, timing-dependent test.

Please summarize the change here.
Comment 3 WebKit Commit Bot 2013-10-07 13:00:19 PDT 
Attachment 213613 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm']" exit_code: 1
Source/WebCore/ChangeLog:19:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2013-10-07 13:26:23 PDT 
http://trac.webkit.org/changeset/157056