WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122464
Animated images are not restarted when page visibility changes
https://bugs.webkit.org/show_bug.cgi?id=122464
Summary
Animated images are not restarted when page visibility changes
Tim Horton
Reported
2013-10-07 12:36:11 PDT
Currently, animated images are kickstarted when a frame moves into the window, but not when the frame just becomes visible. We need to do it in both cases. <
rdar://problem/14293474
>
Attachments
patch
(8.02 KB, patch)
2013-10-07 12:55 PDT
,
Tim Horton
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2013-10-07 12:55:13 PDT
Created
attachment 213613
[details]
patch
Simon Fraser (smfr)
Comment 2
2013-10-07 12:58:23 PDT
Comment on
attachment 213613
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=213613&action=review
> Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + No new tests; attempts to make a test have resulted only in a flaky, timing-dependent test.
Please summarize the change here.
WebKit Commit Bot
Comment 3
2013-10-07 13:00:19 PDT
Attachment 213613
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm']" exit_code: 1 Source/WebCore/ChangeLog:19: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4
2013-10-07 13:26:23 PDT
http://trac.webkit.org/changeset/157056
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug