RESOLVED FIXED 122392
Clean up MessageQueue.h 
https://bugs.webkit.org/show_bug.cgi?id=122392
Summary Clean up MessageQueue.h
Anders Carlsson
Reported 2013-10-05 13:53:25 PDT
Clean up MessageQueue.h
Attachments
Patch (39.16 KB, patch)
2013-10-05 14:01 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (39.17 KB, patch)
2013-10-05 14:37 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-10-05 14:01:19 PDT
Created attachment 213469 [details] Patch
WebKit Commit Bot
Comment 2 2013-10-05 14:02:16 PDT
Attachment 213469 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Deque.h', u'Source/WTF/wtf/MessageQueue.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp', u'Source/WebCore/Modules/webaudio/AsyncAudioDecoder.h', u'Source/WebCore/Modules/webdatabase/Database.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTask.h', u'Source/WebCore/Modules/webdatabase/DatabaseThread.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseThread.h', u'Source/WebCore/dom/default/PlatformMessagePortChannel.cpp', u'Source/WebCore/dom/default/PlatformMessagePortChannel.h', u'Source/WebCore/fileapi/FileThread.cpp', u'Source/WebCore/fileapi/FileThread.h', u'Source/WebCore/fileapi/FileThreadTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/workers/WorkerRunLoop.cpp', u'Source/WebCore/workers/WorkerRunLoop.h']" exit_code: 1 Source/WebCore/storage/StorageThread.cpp:88: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageThread.cpp:100: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/Deque.h:91: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/MessageQueue.h:66: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/MessageQueue.h:69: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/MessageQueue.h:131: More than one command on the same line [whitespace/newline] [4] Total errors found: 6 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2013-10-05 14:37:37 PDT
Created attachment 213471 [details] Patch
WebKit Commit Bot
Comment 4 2013-10-05 14:39:52 PDT
Attachment 213471 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Deque.h', u'Source/WTF/wtf/MessageQueue.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp', u'Source/WebCore/Modules/webaudio/AsyncAudioDecoder.h', u'Source/WebCore/Modules/webdatabase/Database.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseTask.h', u'Source/WebCore/Modules/webdatabase/DatabaseThread.cpp', u'Source/WebCore/Modules/webdatabase/DatabaseThread.h', u'Source/WebCore/dom/default/PlatformMessagePortChannel.cpp', u'Source/WebCore/dom/default/PlatformMessagePortChannel.h', u'Source/WebCore/fileapi/FileThread.cpp', u'Source/WebCore/fileapi/FileThread.h', u'Source/WebCore/fileapi/FileThreadTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/workers/WorkerRunLoop.cpp', u'Source/WebCore/workers/WorkerRunLoop.h']" exit_code: 1 Source/WebCore/storage/StorageThread.cpp:88: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/storage/StorageThread.cpp:100: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/Deque.h:91: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/MessageQueue.h:66: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/MessageQueue.h:69: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/MessageQueue.h:131: More than one command on the same line [whitespace/newline] [4] Total errors found: 6 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 5 2013-10-05 14:53:12 PDT
Committed r156972: <http://trac.webkit.org/changeset/156972>
Note You need to log in before you can comment on or make changes to this bug.