Bug 122342 - Tighten typing in some RenderLayer code.
Summary: Tighten typing in some RenderLayer code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 12:41 PDT by Andreas Kling
Modified: 2013-10-04 15:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.05 KB, patch)
2013-10-04 12:48 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-04 12:41:59 PDT 
Let's tighten some of the Node and RenderObject usage in here.
Comment 1 Andreas Kling 2013-10-04 12:48:39 PDT 
Created attachment 213390 [details]
Patch
Comment 2 Antti Koivisto 2013-10-04 12:51:24 PDT 
Comment on attachment 213390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213390&action=review

> Source/WebCore/rendering/RenderTableRow.h:126
> +inline RenderTableRow& toRenderTableRow(RenderObject& object)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(object.isTableRow());
> +    return static_cast<RenderTableRow&>(object);
> +}

Could add const version too since you are here.
Comment 3 Antti Koivisto 2013-10-04 12:55:31 PDT 
Comment on attachment 213390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213390&action=review

> Source/WebCore/rendering/RenderLayer.cpp:5376
> +            LayoutRect bbox = cell->borderBoxRect();

Uh bbox
Comment 4 WebKit Commit Bot 2013-10-04 15:20:36 PDT 
Comment on attachment 213390 [details]
Patch

Clearing flags on attachment: 213390

Committed r156915: <http://trac.webkit.org/changeset/156915>
Comment 5 WebKit Commit Bot 2013-10-04 15:20:38 PDT 
All reviewed patches have been landed.  Closing bug.