RESOLVED FIXED122209
[EFL] Enable correct behaviour for deleting regional indicator symbols 
https://bugs.webkit.org/show_bug.cgi?id=122209
Summary [EFL] Enable correct behaviour for deleting regional indicator symbols
Krzysztof Wolanski
Reported 2013-10-02 02:12:39 PDT
Regional indicator symbols that are combined should behave as a single character when deleting.
Attachments
proposed patch (3.72 KB, patch)
2013-10-02 03:12 PDT, Krzysztof Wolanski 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
apply suggestions (3.76 KB, patch)
2013-10-04 02:02 PDT, Krzysztof Wolanski 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
rebased patch (3.77 KB, patch)
2013-10-04 06:05 PDT, Krzysztof Wolanski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Krzysztof Wolanski
Comment 1 2013-10-02 03:12:52 PDT
Created attachment 213158 [details] proposed patch
Gyuyoung Kim
Comment 2 2013-10-04 01:07:19 PDT
Comment on attachment 213158 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=213158&action=review LGTM. > Source/WebCore/rendering/RenderText.cpp:-1771 > - HangulState initialState; Please mention this removal in ChangeLog as well.
Krzysztof Wolanski
Comment 3 2013-10-04 02:02:09 PDT
Created attachment 213342 [details] apply suggestions
WebKit Commit Bot
Comment 4 2013-10-04 03:16:45 PDT
Comment on attachment 213342 [details] apply suggestions Rejecting attachment 213342 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 213342, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Tools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 122. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 122. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 122. Full output: http://webkit-queues.appspot.com/results/2869079
Krzysztof Wolanski
Comment 5 2013-10-04 06:05:32 PDT
Created attachment 213354 [details] rebased patch
WebKit Commit Bot
Comment 6 2013-10-04 07:21:07 PDT
Comment on attachment 213354 [details] rebased patch Clearing flags on attachment: 213354 Committed r156888: <http://trac.webkit.org/changeset/156888>
WebKit Commit Bot
Comment 7 2013-10-04 07:21:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.