RESOLVED FIXED122185
Make tests for renderer base types non-virtual 
https://bugs.webkit.org/show_bug.cgi?id=122185
Summary Make tests for renderer base types non-virtual
Antti Koivisto
Reported 2013-10-01 15:03:52 PDT
go faster
Attachments
patch (24.43 KB, patch)
2013-10-01 15:21 PDT, Antti Koivisto 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-10-01 15:21:46 PDT
Created attachment 213125 [details] patch
WebKit Commit Bot
Comment 2 2013-10-01 15:23:40 PDT
Attachment 213125 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp']" exit_code: 1 Source/WebCore/rendering/RenderElement.h:192: Extra space between return and m_baseTypeFlags [whitespace/declaration] [3] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2013-10-01 15:25:02 PDT
Comment on attachment 213125 [details] patch r=me
Antti Koivisto
Comment 4 2013-10-01 15:28:55 PDT
https://trac.webkit.org/r156738
Note You need to log in before you can comment on or make changes to this bug.