RESOLVED FIXED Bug 122106
[Win] Compile errors in WebKit. 
https://bugs.webkit.org/show_bug.cgi?id=122106
Summary [Win] Compile errors in WebKit.
peavo
Reported 2013-09-30 06:56:57 PDT
I get these compile errors when compiling WinCairo: 1>..\..\win\WebFrame.cpp(1231): error C2664: 'WebCore::AnimationController::pauseAnimationAtTime' : cannot convert parameter 1 from 'WebCore::RenderObject *' to 'WebCore::RenderElement *' Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast 1>..\..\win\WebFrame.cpp(1250): error C2664: 'WebCore::AnimationController::pauseTransitionAtTime' : cannot convert parameter 1 from 'WebCore::RenderObject *' to 'WebCore::RenderElement *' Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
Attachments
Patch (4.90 KB, patch)
2013-09-30 07:02 PDT, peavo 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-09-30 07:02:55 PDT
Created attachment 212991 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-30 10:46:00 PDT
Comment on attachment 212991 [details] Patch Rejecting attachment 212991 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 212991, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: og patching file Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in patching file Source/WebKit/win/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/win/WebFrame.cpp Hunk #2 FAILED at 1229. Hunk #3 FAILED at 1248. 2 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/win/WebFrame.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/2733116
peavo
Comment 3 2013-09-30 10:52:13 PDT
Already fixed in r156655, except for the link fixes.
Darin Adler
Comment 4 2013-09-30 11:01:36 PDT
OK, then someone needs to land the link fixes.
Brent Fulgham
Comment 5 2013-09-30 11:08:25 PDT
I'll land the link fixes.
Brent Fulgham
Comment 6 2013-09-30 11:13:33 PDT
Landed in http://trac.webkit.org/changeset/156667.
Note You need to log in before you can comment on or make changes to this bug.