Bug 121903 - htmlediting.cpp: unnecessary local variable cleanup
Summary: htmlediting.cpp: unnecessary local variable cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-25 06:17 PDT by Santosh Mahto
Modified: 2013-09-25 18:59 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2013-09-25 06:23 PDT, Santosh Mahto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Santosh Mahto 2013-09-25 06:17:32 PDT
Node* lowestRoot = 0  is not used any where in function so removing it.
Comment 1 Santosh Mahto 2013-09-25 06:23:52 PDT
Created attachment 212566 [details]
Patch
Comment 2 Darin Adler 2013-09-25 18:36:29 PDT
Comment on attachment 212566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212566&action=review

> Source/WebCore/editing/htmlediting.cpp:145
> +    return 0;

Should be nullptr rather than 0 in new code.
Comment 3 WebKit Commit Bot 2013-09-25 18:59:50 PDT
Comment on attachment 212566 [details]
Patch

Clearing flags on attachment: 212566

Committed r156442: <http://trac.webkit.org/changeset/156442>
Comment 4 WebKit Commit Bot 2013-09-25 18:59:52 PDT
All reviewed patches have been landed.  Closing bug.