WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121903
htmlediting.cpp: unnecessary local variable cleanup
https://bugs.webkit.org/show_bug.cgi?id=121903
Summary
htmlediting.cpp: unnecessary local variable cleanup
Santosh Mahto
Reported
2013-09-25 06:17:32 PDT
Node* lowestRoot = 0 is not used any where in function so removing it.
Attachments
Patch
(1.42 KB, patch)
2013-09-25 06:23 PDT
,
Santosh Mahto
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Santosh Mahto
Comment 1
2013-09-25 06:23:52 PDT
Created
attachment 212566
[details]
Patch
Darin Adler
Comment 2
2013-09-25 18:36:29 PDT
Comment on
attachment 212566
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=212566&action=review
> Source/WebCore/editing/htmlediting.cpp:145 > + return 0;
Should be nullptr rather than 0 in new code.
WebKit Commit Bot
Comment 3
2013-09-25 18:59:50 PDT
Comment on
attachment 212566
[details]
Patch Clearing flags on attachment: 212566 Committed
r156442
: <
http://trac.webkit.org/changeset/156442
>
WebKit Commit Bot
Comment 4
2013-09-25 18:59:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug