Bug 121837 - [WIN] Add executable entry points to DRT and WinLauncher
Summary: [WIN] Add executable entry points to DRT and WinLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 06:04 PDT by Patrick R. Gansterer
Modified: 2013-10-30 12:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2013-09-24 06:07 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-09-24 06:04:51 PDT 
[WIN] Add executable entry points to DRT and WinLauncher
Comment 1 Patrick R. Gansterer 2013-09-24 06:07:52 PDT 
Created attachment 212457 [details]
Patch
Comment 2 Brent Fulgham 2013-09-25 11:44:38 PDT 
Comment on attachment 212457 [details]
Patch

What is the point of this patch? Why do you want to move away from the simple loader program running a separate DLL?
Comment 3 Patrick R. Gansterer 2013-09-25 11:54:43 PDT 
(In reply to comment #2)
> (From update of attachment 212457 [details])
> What is the point of this patch? Why do you want to move away from the simple loader program running a separate DLL?

a) makes SLN files "smaller" and easier to understand
b) DLLLauncher is IMHO a workaround for Apple DLLs:
  - Embeds the MSVC80 CRT manifest
  - Requires that the path to the Apple DLLs exist on the system
Comment 4 Brent Fulgham 2013-10-30 10:16:58 PDT 
Comment on attachment 212457 [details]
Patch

We will not accept this patch, as it removes functionality we need.
Comment 5 Patrick R. Gansterer 2013-10-30 10:21:25 PDT 
Comment on attachment 212457 [details]
Patch

(In reply to comment #4)
> (From update of attachment 212457 [details])
> We will not accept this patch, as it removes functionality we need.

It does not remove functionality! It's ok that the Apple port needs the *Launcher applications, but the Cairo port does not. Having additional binaries adds no value there. I don't see a big problem in splitting this function, so the build system can decide how to link it (with or without *Launcher)
Comment 6 Brent Fulgham 2013-10-30 11:25:35 PDT 
Comment on attachment 212457 [details]
Patch

r=me.
Comment 7 WebKit Commit Bot 2013-10-30 12:09:00 PDT 
Comment on attachment 212457 [details]
Patch

Clearing flags on attachment: 212457

Committed r158302: <http://trac.webkit.org/changeset/158302>
Comment 8 WebKit Commit Bot 2013-10-30 12:09:03 PDT 
All reviewed patches have been landed.  Closing bug.