Bug 121837 – [WIN] Add executable entry points to DRT and WinLauncher

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Patrick R. Gansterer]

[WIN] Add executable entry points to DRT and WinLauncher

[Patrick R. Gansterer]

Created attachment 212457 [details]
Patch

[Brent Fulgham]

Comment on attachment 212457 [details]
Patch

What is the point of this patch? Why do you want to move away from the simple loader program running a separate DLL?

[Patrick R. Gansterer]

(In reply to comment #2)
> (From update of attachment 212457 [details])
> What is the point of this patch? Why do you want to move away from the simple loader program running a separate DLL?

a) makes SLN files "smaller" and easier to understand
b) DLLLauncher is IMHO a workaround for Apple DLLs:
  - Embeds the MSVC80 CRT manifest
  - Requires that the path to the Apple DLLs exist on the system

[Brent Fulgham]

Comment on attachment 212457 [details]
Patch

We will not accept this patch, as it removes functionality we need.

[Patrick R. Gansterer]

Comment on attachment 212457 [details]
Patch

(In reply to comment #4)
> (From update of attachment 212457 [details])
> We will not accept this patch, as it removes functionality we need.

It does not remove functionality! It's ok that the Apple port needs the *Launcher applications, but the Cairo port does not. Having additional binaries adds no value there. I don't see a big problem in splitting this function, so the build system can decide how to link it (with or without *Launcher)

[Brent Fulgham]

Comment on attachment 212457 [details]
Patch

r=me.

[WebKit Commit Bot]

Comment on attachment 212457 [details]
Patch

Clearing flags on attachment: 212457

Committed r158302: <http://trac.webkit.org/changeset/158302>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.