Bug 121831 - [EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
Summary: [EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 03:25 PDT by Krzysztof Wolanski
Modified: 2013-09-27 06:29 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (2.26 KB, patch)
2013-09-25 03:28 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
apply suggestions (2.26 KB, patch)
2013-09-25 07:56 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
apply suggestions (2.24 KB, patch)
2013-09-26 02:20 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
apply suggestions (2.24 KB, patch)
2013-09-26 05:07 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Wolanski 2013-09-24 03:25:31 PDT 
Updating baselines in selection and deleting.
Comment 1 Krzysztof Wolanski 2013-09-25 03:28:14 PDT 
Created attachment 212550 [details]
proposed patch
Comment 2 Grzegorz Czajkowski 2013-09-25 07:38:15 PDT 
Comment on attachment 212550 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212550&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] Update test expectations after enabling subpixel layout and updating freetype (r140136)

The revision which the title refers to is wrong. It has been committed to update test expectations as a result of updating freetype (mostly). To be correspond with other gardening patches it would be the best to find a revision which caused the test failure.
Comment 3 Krzysztof Wolanski 2013-09-25 07:56:27 PDT 
Created attachment 212579 [details]
apply suggestions
Comment 4 Grzegorz Czajkowski 2013-09-26 01:24:23 PDT 
Comment on attachment 212579 [details]
apply suggestions

View in context: https://bugs.webkit.org/attachment.cgi?id=212579&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] Update test expectations after enabling subpixel layout and updating freetype (r140111)

I should have noticed it in the previous review but I think the title "[EFL] editing/selection/fake-doubleclick.html rebaseline after r140111" better refers to the change. I'm sorry for that.
Comment 5 Krzysztof Wolanski 2013-09-26 02:20:23 PDT 
Created attachment 212680 [details]
apply suggestions
Comment 6 Krzysztof Wolanski 2013-09-26 05:07:13 PDT 
Created attachment 212693 [details]
apply suggestions
Comment 7 WebKit Commit Bot 2013-09-27 06:29:50 PDT 
Comment on attachment 212693 [details]
apply suggestions

Clearing flags on attachment: 212693

Committed r156539: <http://trac.webkit.org/changeset/156539>
Comment 8 WebKit Commit Bot 2013-09-27 06:29:52 PDT 
All reviewed patches have been landed.  Closing bug.