RESOLVED FIXED Bug 121831
[EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
https://bugs.webkit.org/show_bug.cgi?id=121831
Summary [EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
Krzysztof Wolanski
Reported 2013-09-24 03:25:31 PDT
Updating baselines in selection and deleting.
Attachments
proposed patch (2.26 KB, patch)
2013-09-25 03:28 PDT, Krzysztof Wolanski
no flags
apply suggestions (2.26 KB, patch)
2013-09-25 07:56 PDT, Krzysztof Wolanski
no flags
apply suggestions (2.24 KB, patch)
2013-09-26 02:20 PDT, Krzysztof Wolanski
no flags
apply suggestions (2.24 KB, patch)
2013-09-26 05:07 PDT, Krzysztof Wolanski
no flags
Krzysztof Wolanski
Comment 1 2013-09-25 03:28:14 PDT
Created attachment 212550 [details] proposed patch
Grzegorz Czajkowski
Comment 2 2013-09-25 07:38:15 PDT
Comment on attachment 212550 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=212550&action=review > LayoutTests/ChangeLog:3 > + [EFL] Update test expectations after enabling subpixel layout and updating freetype (r140136) The revision which the title refers to is wrong. It has been committed to update test expectations as a result of updating freetype (mostly). To be correspond with other gardening patches it would be the best to find a revision which caused the test failure.
Krzysztof Wolanski
Comment 3 2013-09-25 07:56:27 PDT
Created attachment 212579 [details] apply suggestions
Grzegorz Czajkowski
Comment 4 2013-09-26 01:24:23 PDT
Comment on attachment 212579 [details] apply suggestions View in context: https://bugs.webkit.org/attachment.cgi?id=212579&action=review > LayoutTests/ChangeLog:3 > + [EFL] Update test expectations after enabling subpixel layout and updating freetype (r140111) I should have noticed it in the previous review but I think the title "[EFL] editing/selection/fake-doubleclick.html rebaseline after r140111" better refers to the change. I'm sorry for that.
Krzysztof Wolanski
Comment 5 2013-09-26 02:20:23 PDT
Created attachment 212680 [details] apply suggestions
Krzysztof Wolanski
Comment 6 2013-09-26 05:07:13 PDT
Created attachment 212693 [details] apply suggestions
WebKit Commit Bot
Comment 7 2013-09-27 06:29:50 PDT
Comment on attachment 212693 [details] apply suggestions Clearing flags on attachment: 212693 Committed r156539: <http://trac.webkit.org/changeset/156539>
WebKit Commit Bot
Comment 8 2013-09-27 06:29:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.