Bug 121530 - REGRESSION(r156019): broke the Mac and Windows builds (Requested by thorton on #webkit).
Summary: REGRESSION(r156019): broke the Mac and Windows builds (Requested by thorton o...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 121064
  Show dependency tree / graph
 
Reported: 2013-09-17 18:46 PDT by WebKit Commit Bot
Modified: 2013-09-17 19:04 PDT (History)
3 users (show)

See Also:

Attachments
ROLLOUT of r156019 (221.20 KB, patch)
2013-09-17 18:46 PDT, WebKit Commit Bot 		fpizlo: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-09-17 18:46:05 PDT 
http://trac.webkit.org/changeset/156019 broke the build:
broke the Mac and Windows builds (Requested by thorton on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 Filip Pizlo 2013-09-17 18:46:34 PDT 
I have a fix.
Comment 2 WebKit Commit Bot 2013-09-17 18:46:38 PDT 
Created attachment 211963 [details]
ROLLOUT of r156019

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 3 Filip Pizlo 2013-09-17 18:48:11 PDT 
Fix landed in http://trac.webkit.org/changeset/156020
Comment 4 Filip Pizlo 2013-09-17 18:48:50 PDT 
Comment on attachment 211963 [details]
ROLLOUT of r156019

I believe that my fix should work, but even if it doesn't it means that this patch won't apply anymore.
Comment 5 Tim Horton 2013-09-17 19:04:51 PDT 
(In reply to comment #4)
> (From update of attachment 211963 [details])
> I believe that my fix should work, but even if it doesn't it means that this patch won't apply anymore.

I think it did, for Windows at least. Thanks!