WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
121530
REGRESSION(
r156019
): broke the Mac and Windows builds (Requested by thorton on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=121530
Summary
REGRESSION(r156019): broke the Mac and Windows builds (Requested by thorton o...
WebKit Commit Bot
Reported
2013-09-17 18:46:05 PDT
http://trac.webkit.org/changeset/156019
broke the build: broke the Mac and Windows builds (Requested by thorton on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r156019
(221.20 KB, patch)
2013-09-17 18:46 PDT
,
WebKit Commit Bot
fpizlo
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2013-09-17 18:46:34 PDT
I have a fix.
WebKit Commit Bot
Comment 2
2013-09-17 18:46:38 PDT
Created
attachment 211963
[details]
ROLLOUT of
r156019
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Filip Pizlo
Comment 3
2013-09-17 18:48:11 PDT
Fix landed in
http://trac.webkit.org/changeset/156020
Filip Pizlo
Comment 4
2013-09-17 18:48:50 PDT
Comment on
attachment 211963
[details]
ROLLOUT of
r156019
I believe that my fix should work, but even if it doesn't it means that this patch won't apply anymore.
Tim Horton
Comment 5
2013-09-17 19:04:51 PDT
(In reply to
comment #4
)
> (From update of
attachment 211963
[details]
) > I believe that my fix should work, but even if it doesn't it means that this patch won't apply anymore.
I think it did, for Windows at least. Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug