Bug 121449 - CTTE: Element::createRenderer() should take references
Summary: CTTE: Element::createRenderer() should take references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-16 12:45 PDT by Sam Weinig
Modified: 2013-09-16 15:18 PDT (History)
1 user (show)

See Also:


Attachments
Patch (120.83 KB, patch)
2013-09-16 14:26 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-16 12:45:10 PDT
CTTE: Element::createRenderer() should take references
Comment 1 Sam Weinig 2013-09-16 14:26:17 PDT
Created attachment 211829 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-16 14:29:03 PDT
Attachment 211829 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/Text.cpp', u'Source/WebCore/dom/Text.h', u'Source/WebCore/html/BaseButtonInputType.cpp', u'Source/WebCore/html/BaseButtonInputType.h', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FileInputType.h', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAppletElement.h', u'Source/WebCore/html/HTMLBRElement.cpp', u'Source/WebCore/html/HTMLBRElement.h', u'Source/WebCore/html/HTMLButtonElement.cpp', u'Source/WebCore/html/HTMLButtonElement.h', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.h', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLDetailsElement.h', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFieldSetElement.cpp', u'Source/WebCore/html/HTMLFieldSetElement.h', u'Source/WebCore/html/HTMLFrameElement.cpp', u'Source/WebCore/html/HTMLFrameElement.h', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.h', u'Source/WebCore/html/HTMLIFrameElement.cpp', u'Source/WebCore/html/HTMLIFrameElement.h', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLImageElement.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLMeterElement.cpp', u'Source/WebCore/html/HTMLMeterElement.h', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.h', u'Source/WebCore/html/HTMLProgressElement.cpp', u'Source/WebCore/html/HTMLProgressElement.h', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLSelectElement.h', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/HTMLSummaryElement.h', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.h', u'Source/WebCore/html/HTMLVideoElement.cpp', u'Source/WebCore/html/HTMLVideoElement.h', u'Source/WebCore/html/HiddenInputType.cpp', u'Source/WebCore/html/HiddenInputType.h', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/ImageInputType.h', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/RangeInputType.h', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/SearchInputType.h', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/TextFieldInputType.h', u'Source/WebCore/html/shadow/DetailsMarkerControl.cpp', u'Source/WebCore/html/shadow/DetailsMarkerControl.h', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControlElements.h', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.h', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.h', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.h', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/mathml/MathMLInlineContainerElement.cpp', u'Source/WebCore/mathml/MathMLInlineContainerElement.h', u'Source/WebCore/mathml/MathMLMathElement.cpp', u'Source/WebCore/mathml/MathMLMathElement.h', u'Source/WebCore/mathml/MathMLTextElement.cpp', u'Source/WebCore/mathml/MathMLTextElement.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderReplica.cpp', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/style/ContentData.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAElement.cpp', u'Source/WebCore/svg/SVGAElement.h', u'Source/WebCore/svg/SVGAltGlyphElement.cpp', u'Source/WebCore/svg/SVGAltGlyphElement.h', u'Source/WebCore/svg/SVGCircleElement.cpp', u'Source/WebCore/svg/SVGCircleElement.h', u'Source/WebCore/svg/SVGClipPathElement.cpp', u'Source/WebCore/svg/SVGClipPathElement.h', u'Source/WebCore/svg/SVGDefsElement.cpp', u'Source/WebCore/svg/SVGDefsElement.h', u'Source/WebCore/svg/SVGEllipseElement.cpp', u'Source/WebCore/svg/SVGEllipseElement.h', u'Source/WebCore/svg/SVGFilterElement.cpp', u'Source/WebCore/svg/SVGFilterElement.h', u'Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp', u'Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h', u'Source/WebCore/svg/SVGForeignObjectElement.cpp', u'Source/WebCore/svg/SVGForeignObjectElement.h', u'Source/WebCore/svg/SVGGElement.cpp', u'Source/WebCore/svg/SVGGElement.h', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGGraphicsElement.h', u'Source/WebCore/svg/SVGImageElement.cpp', u'Source/WebCore/svg/SVGImageElement.h', u'Source/WebCore/svg/SVGLinearGradientElement.cpp', u'Source/WebCore/svg/SVGLinearGradientElement.h', u'Source/WebCore/svg/SVGMarkerElement.cpp', u'Source/WebCore/svg/SVGMarkerElement.h', u'Source/WebCore/svg/SVGMaskElement.cpp', u'Source/WebCore/svg/SVGMaskElement.h', u'Source/WebCore/svg/SVGPathElement.cpp', u'Source/WebCore/svg/SVGPathElement.h', u'Source/WebCore/svg/SVGPatternElement.cpp', u'Source/WebCore/svg/SVGPatternElement.h', u'Source/WebCore/svg/SVGRadialGradientElement.cpp', u'Source/WebCore/svg/SVGRadialGradientElement.h', u'Source/WebCore/svg/SVGRectElement.cpp', u'Source/WebCore/svg/SVGRectElement.h', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGSVGElement.h', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGStopElement.h', u'Source/WebCore/svg/SVGSwitchElement.cpp', u'Source/WebCore/svg/SVGSwitchElement.h', u'Source/WebCore/svg/SVGSymbolElement.cpp', u'Source/WebCore/svg/SVGSymbolElement.h', u'Source/WebCore/svg/SVGTRefElement.cpp', u'Source/WebCore/svg/SVGTRefElement.h', u'Source/WebCore/svg/SVGTSpanElement.cpp', u'Source/WebCore/svg/SVGTSpanElement.h', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/SVGTextElement.h', u'Source/WebCore/svg/SVGTextPathElement.cpp', u'Source/WebCore/svg/SVGTextPathElement.h', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h']" exit_code: 1
Source/WebCore/rendering/RenderObject.cpp:189:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 167 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2013-09-16 15:18:59 PDT
Committed r155908: <http://trac.webkit.org/changeset/155908>