Bug 121379 - Get rid of ref-counting on RenderArena.
Summary: Get rid of ref-counting on RenderArena.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-15 00:33 PDT by Andreas Kling
Modified: 2013-09-15 01:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2013-09-15 00:34 PDT, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-15 00:33:26 PDT 
Get rid of ref-counting on RenderArena.
Comment 1 Andreas Kling 2013-09-15 00:34:34 PDT 
Created attachment 211689 [details]
Patch
Comment 2 Darin Adler 2013-09-15 00:50:37 PDT 
Comment on attachment 211689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211689&action=review

> Source/WebCore/dom/Document.h:1380
> -    RefPtr<RenderArena> m_renderArena;
> +    OwnPtr<RenderArena> m_renderArena;

Maybe just RenderArena would be even better? Maybe not.

> Source/WebCore/rendering/RenderArena.h:46
> +class RenderArena {

Needs noncopyableness. Used to just inherit that from RefCounted.
Comment 3 Andreas Kling 2013-09-15 01:20:23 PDT 
Committed r155800: <http://trac.webkit.org/changeset/155800>