RESOLVED FIXED 121256
[GTK] Switch the 64-bit Release builder to testing layout tests under WK2 
https://bugs.webkit.org/show_bug.cgi?id=121256
Summary [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
Zan Dobersek
Reported 2013-09-12 13:42:37 PDT
[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
Attachments
Patch (3.01 KB, patch)
2013-09-12 13:54 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-09-12 13:54:30 PDT
Created attachment 211470 [details] Patch
Zan Dobersek
Comment 2 2013-09-12 13:55:04 PDT
Shall we?
Martin Robinson
Comment 3 2013-09-12 13:56:43 PDT
I'd really like to make the switch. There are some WebKit2 tests failing, but fixing them will be easier if we have fast bots verifying tests.
Zan Dobersek
Comment 4 2013-09-13 00:28:52 PDT
Should we also switch the debug builder to testing WK2?
Carlos Garcia Campos
Comment 5 2013-09-13 00:31:38 PDT
(In reply to comment #2) > Shall we? Definitely.
Carlos Garcia Campos
Comment 6 2013-09-13 00:32:55 PDT
(In reply to comment #4) > Should we also switch the debug builder to testing WK2? I think the test coverage is still better in WebKit1, so for now I would keep this bot running layout tests in wk1, unless we can have a different bot running test in wk1.
Zan Dobersek
Comment 7 2013-09-23 08:06:32 PDT
Any further opinion on this? Can we get the change rolling?
Martin Robinson
Comment 8 2013-09-23 10:42:35 PDT
Comment on attachment 211470 [details] Patch Sounds like everyone is in favor. Let's give this a shot.
Zan Dobersek
Comment 9 2013-09-25 12:11:47 PDT
Comment on attachment 211470 [details] Patch Clearing flags on attachment: 211470 Committed r156417: <http://trac.webkit.org/changeset/156417>
Zan Dobersek
Comment 10 2013-09-25 12:11:53 PDT
All reviewed patches have been landed. Closing bug.
Zan Dobersek
Comment 11 2013-09-25 12:17:38 PDT
(In reply to comment #9) > Committed r156417: <http://trac.webkit.org/changeset/156417> Hi Lucas -- could you please restart the BuildBot master so these changes come into effect?
Lucas Forschler
Comment 12 2013-09-25 15:52:33 PDT
Done, sorry for the delay!
Note You need to log in before you can comment on or make changes to this bug.