Bug 121256 - [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
Summary: [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 13:42 PDT by Zan Dobersek
Modified: 2013-09-25 15:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2013-09-12 13:54 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-09-12 13:42:37 PDT 
[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
Comment 1 Zan Dobersek 2013-09-12 13:54:30 PDT 
Created attachment 211470 [details]
Patch
Comment 2 Zan Dobersek 2013-09-12 13:55:04 PDT 
Shall we?
Comment 3 Martin Robinson 2013-09-12 13:56:43 PDT 
I'd really like to make the switch. There are some WebKit2 tests failing, but fixing them will be easier if we have fast bots verifying tests.
Comment 4 Zan Dobersek 2013-09-13 00:28:52 PDT 
Should we also switch the debug builder to testing WK2?
Comment 5 Carlos Garcia Campos 2013-09-13 00:31:38 PDT 
(In reply to comment #2)
> Shall we?

Definitely.
Comment 6 Carlos Garcia Campos 2013-09-13 00:32:55 PDT 
(In reply to comment #4)
> Should we also switch the debug builder to testing WK2?

I think the test coverage is still better in WebKit1, so for now I would keep this bot running layout tests in wk1, unless we can have a different bot running test in wk1.
Comment 7 Zan Dobersek 2013-09-23 08:06:32 PDT 
Any further opinion on this? Can we get the change rolling?
Comment 8 Martin Robinson 2013-09-23 10:42:35 PDT 
Comment on attachment 211470 [details]
Patch

Sounds like everyone is in favor. Let's give this a shot.
Comment 9 Zan Dobersek 2013-09-25 12:11:47 PDT 
Comment on attachment 211470 [details]
Patch

Clearing flags on attachment: 211470

Committed r156417: <http://trac.webkit.org/changeset/156417>
Comment 10 Zan Dobersek 2013-09-25 12:11:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Zan Dobersek 2013-09-25 12:17:38 PDT 
(In reply to comment #9)
> Committed r156417: <http://trac.webkit.org/changeset/156417>

Hi Lucas -- could you please restart the BuildBot master so these changes come into effect?
Comment 12 Lucas Forschler 2013-09-25 15:52:33 PDT 
Done, sorry for the delay!