RenderWidget elements are always HTMLFrameOwnerElement subclasses.
Created attachment 211407 [details] Patch
Attachment 211407 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFrame.cpp', u'Source/WebCore/rendering/RenderFrameBase.cpp', u'Source/WebCore/rendering/RenderFrameBase.h', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RenderWidget.h']" exit_code: 1 Source/WebCore/rendering/RenderWidget.h:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r155598: <http://trac.webkit.org/changeset/155598>
(In reply to comment #3) > Committed r155598: <http://trac.webkit.org/changeset/155598> This broke the build for ports that enable PLUGIN_PROXY_FOR_VIDEO (*), such as iOS WebKit, with a build error of the form: Source/WebCore/html/HTMLMediaElement.cpp:623:55: error: no matching constructor for initialization of 'WebCore::RenderEmbeddedObject' In file included from Source/WebCore/html/HTMLMediaElement.cpp:34: In file included from Source/WebCore/page/ChromeClient.h:35: Source/WebCore/rendering/RenderEmbeddedObject.h:36:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'WebCore::HTMLMediaElement *' to 'const WebCore::RenderEmbeddedObject' for 1st argument class RenderEmbeddedObject : public RenderWidget { Source/WebCore/rendering/RenderEmbeddedObject.h:38:5: note: candidate constructor not viable: no known conversion from 'WebCore::HTMLMediaElement *' to 'WebCore::HTMLFrameOwnerElement *' for 1st argument Notice that HTMLMediaElement extends HTMLElement (as of r155811) instead of HTMLFrameOwnerElement or some derived class of it. (*) We should look to setup a bot on build.webkit.org to build with PLUGIN_PROXY_FOR_VIDEO enabled to help catch such build failures.