Bug 12096 - SVGImage and PDFDocumentImage need support for drawTiled
Summary: SVGImage and PDFDocumentImage need support for drawTiled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords: SVGHitList
Depends on:
Blocks:
 
Reported: 2007-01-03 08:03 PST by Eric Seidel (no email)
Modified: 2007-01-17 04:36 PST (History)
0 users

See Also:


Attachments
simple support (27.42 KB, patch)
2007-01-17 03:45 PST, Eric Seidel (no email)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-01-03 08:03:35 PST
SVGImage and PDFDocumentImage need support for drawTiled

Both SVGImage and PDFDocumentImage currently have empty drawTiled implementations.  In order to draw correctly as background images (or border images), these will both need drawTiled implementations.

Perhaps it will be possible to push some of BitmapImage::drawTiled logic down into Image and re-use it for SVGImage and PDFDocumentImage

This is important for having compelling SVG support in the next version of WebKit.  Most authors will likely use SVG through <img> or CSS background images.
Comment 1 Eric Seidel (no email) 2007-01-17 03:45:47 PST
Created attachment 12502 [details]
simple support

This support does not handle dynamic images or SVGs with dynamic sizing.  I think the pattern drawing system still needs some additional re-factoring for really good support.
Comment 2 Eric Seidel (no email) 2007-01-17 04:34:54 PST
Fixed.

Now we just need size negotiation for really cool svg-as-image support:
http://bugs.webkit.org/show_bug.cgi?id=12095
Comment 3 mitz 2007-01-17 04:36:08 PST
Comment on attachment 12502 [details]
simple support

r=me with changes we discussed on IRC