Let's see if we can get rid of this dependency.
Created attachment 210778 [details] EWS experiment
Attachment 210778 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/generic/GenericBinding.h', u'Source/WebCore/bindings/js/JSCallbackData.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMainThreadExecStateInstrumentation.h', u'Source/WebCore/bindings/js/JSMutationCallback.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/ElementRuleCollector.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SelectorChecker.h', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm']" exit_code: 1 Source/WebCore/bindings/generic/GenericBinding.h:36: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/bindings/js/JSMainThreadExecStateInstrumentation.h:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 210778 [details] EWS experiment Attachment 210778 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1718083
Comment on attachment 210778 [details] EWS experiment Attachment 210778 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1718084
Comment on attachment 210778 [details] EWS experiment Attachment 210778 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1710365
Created attachment 210779 [details] EWS experiment 2
Created attachment 210792 [details] Patch
Created attachment 210796 [details] Patch
Attachment 210796 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/generic/GenericBinding.h', u'Source/WebCore/bindings/js/JSCallbackData.cpp', u'Source/WebCore/bindings/js/JSEventListener.cpp', u'Source/WebCore/bindings/js/JSMainThreadExecState.h', u'Source/WebCore/bindings/js/JSMainThreadExecStateInstrumentation.h', u'Source/WebCore/bindings/js/JSMutationCallback.cpp', u'Source/WebCore/bindings/js/ScheduledAction.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/ElementRuleCollector.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SelectorChecker.h', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/ewk/ewk_paint_context.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm']" exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 210798 [details] Patch
Comment on attachment 210798 [details] Patch Doesn't apply anymore? Meh, I'll just land this manually.
00:05:08 < WKR> https://trac.webkit.org/r155217 by Andreas Kling (kling) Include Frame.h in fewer places. <https://webkit.org/b/120868> Reviewed by Anders Carlsson (andersca).