EFL entry's cursor interval is set to 0.6.
Created attachment 210275 [details] Patch
Comment on attachment 210275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210275&action=review > Source/WebCore/platform/efl/RenderThemeEfl.h:119 > + virtual double caretBlinkInterval() const { return 0.6; } Would you please move the implementation to the cpp file, add a global constant for the magic 0.6 value with a comment explaining why we use this value?
Comment on attachment 210275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210275&action=review >> Source/WebCore/platform/efl/RenderThemeEfl.h:119 >> + virtual double caretBlinkInterval() const { return 0.6; } > > Would you please move the implementation to the cpp file, add a global constant for the magic 0.6 value with a comment explaining why we use this value? Also, you are missing OVERRIDE.
Comment on attachment 210275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210275&action=review > Source/WebCore/ChangeLog:8 > + Set caret interval as 0.6 to synchronize with EFL entry's cursor interval. I wonder if EFL entry's cursor interval is working. It looks it doesn't work now, isn't it ? I think we need to make a rule or a policy to set the cursor interval as port ports.
(In reply to comment #4) > (From update of attachment 210275 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=210275&action=review > > > Source/WebCore/ChangeLog:8 > > + Set caret interval as 0.6 to synchronize with EFL entry's cursor interval. > > I wonder if EFL entry's cursor interval is working. It looks it doesn't work now, isn't it ? I think we need to make a rule or a policy to set the cursor interval as port ports. Cursor interval depends on Theme. Elementary default theme use 0.2 (now) Tizen use 0.6 as interval. EFL Dark theme(recently working on progress) are now using 0.5/0.2 (show/hide). If we want to synchronize caret interval with EFL, we'd better to get information from edc.
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 210275 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=210275&action=review > > > > > Source/WebCore/ChangeLog:8 > > > + Set caret interval as 0.6 to synchronize with EFL entry's cursor interval. > > > > I wonder if EFL entry's cursor interval is working. It looks it doesn't work now, isn't it ? I think we need to make a rule or a policy to set the cursor interval as port ports. > > Cursor interval depends on Theme. > Elementary default theme use 0.2 (now) > Tizen use 0.6 as interval. > EFL Dark theme(recently working on progress) are now using 0.5/0.2 (show/hide). > > If we want to synchronize caret interval with EFL, we'd better to get information from edc. s/theme/edc
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 210275 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=210275&action=review > > > > > Source/WebCore/ChangeLog:8 > > > + Set caret interval as 0.6 to synchronize with EFL entry's cursor interval. > > > > I wonder if EFL entry's cursor interval is working. It looks it doesn't work now, isn't it ? I think we need to make a rule or a policy to set the cursor interval as port ports. > > Cursor interval depends on Theme. > Elementary default theme use 0.2 (now) > Tizen use 0.6 as interval. > EFL Dark theme(recently working on progress) are now using 0.5/0.2 (show/hide). > > If we want to synchronize caret interval with EFL, we'd better to get information from edc. Yes, I don't mind to get the interval information from edc. That can be our policy. My point is we need to make a policy how to set the interval value. Ryuan, do you know if we can get the information from theme or edc file ?
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.